Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Close FormData (uploaded files) after the request is done #5465

Merged
merged 8 commits into from Nov 3, 2022
Merged

🐛 Close FormData (uploaded files) after the request is done #5465

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
866cdcb
automatically close FormData
adriangb Oct 6, 2022
1dbbab6
automatically close FormData
adriangb Oct 6, 2022
c9d151f
Merge branch 'master' into close-uploadfile
adriangb Oct 11, 2022
2841a7a
Merge branch 'master' into close-uploadfile
adriangb Oct 22, 2022
8a28c02
Merge branch 'master' into close-uploadfile
adriangb Oct 31, 2022
1887507
Merge branch 'master' into close-uploadfile
adriangb Oct 31, 2022
a1fa01b
Merge branch 'master' into close-uploadfile
adriangb Oct 31, 2022
adcdf4d
✅ Add test to check that upload files are closed after the request is…
tiangolo Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions fastapi/routing.py
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@
import email.message
import inspect
import json
from contextlib import AsyncExitStack
from enum import Enum, IntEnum
from typing import (
Any,
Expand Down Expand Up @@ -190,6 +191,9 @@ async def app(request: Request) -> Response:
if body_field:
if is_body_form:
body = await request.form()
stack = request.scope.get("fastapi_astack")
assert isinstance(stack, AsyncExitStack)
stack.push_async_callback(body.close)
else:
body_bytes = await request.body()
if body_bytes:
Expand Down