🐛 Close FormData (uploaded files) after the request is done #5465
Conversation
|
📝 Docs preview for commit 1dbbab6 at: https://633efa56cd26a21a02038871--fastapi.netlify.app |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5465 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13946 13969 +23
=========================================
+ Hits 13946 13969 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks like failures are unrelated to this change: #5467 |
|
📝 Docs preview for commit c9d151f at: https://6345ec6f26f61e4cf776afde--fastapi.netlify.app |
|
Failures resolved, @tiangolo I think this is ready for review :) |
|
📝 Docs preview for commit 2841a7a at: https://635395c8c62971556f3d83d9--fastapi.netlify.app |
|
Amazing, thank you @adriangb! 🙇 Do you think you could add a test or two for this? |
|
I think this might difficult to test without touching the internals of something. It does run for every test, so we know that it doesn’t crash at least. I’ll think a bit about how to test this. |
|
📝 Docs preview for commit 8a28c02 at: https://636003d3f67bae05d1213030--fastapi.netlify.app |
|
📝 Docs preview for commit 1887507 at: https://636014d7a81e9f143d87f066--fastapi.netlify.app |
|
So it seems like even Starlette is not testing that |
|
📝 Docs preview for commit a1fa01b at: https://636033086842892df4729409--fastapi.netlify.app |
|
📝 Docs preview for commit adcdf4d at: https://6363ae2be9a9080232218a2a--fastapi.netlify.app |
tiangolo
changed the title
|
I found a way to test it! 🎉 I added the commit on top. Thanks for the contribution! 🚀 |
|
That was genius! |
|
Haha thank you! 😊🙈🤓 |
No description provided.