Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃寪 Add Polish translation for
docs/pl/docs/features.md
#5348馃寪 Add Polish translation for
docs/pl/docs/features.md
#5348Changes from 2 commits
97d087c
0b1f548
f5e0ba1
19724d0
093546d
834ad80
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree that the name Dependency Injection is so well known that most likely even non-english speaking programmers are likely to be familiar with it and the feature itself is a key feature of FastAPI, I still think that the term Wstrzykiwanie Zale偶no艣ci should be used here. It's well established in polish literature.
I would suggest going with:
Wstrzykiwanie Zale偶no艣ci (Dependency Injection)
or the other way around:
Dependency Injection (Wstrzykiwanie Zale偶no艣ci)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about it for a while, but then I noticed that in some other language versions of documentation it's translated, and in others it's not.
So I've decided to go with the same pattern as in spanish translation, which is using "Dependency Injection" as a header but in the next line is adding title for another occurrence, but with explaination in spanish:
My reasoning for it was that "Dependency Injection" is definitely used more often in web development industry than "Wstrzykiwanie Zale偶no艣ci", but anyway, to not leaving it untranslated, I've provided translation for it in the next line.
But I agree with you, I'll go with just "Wstrzykiwanie Zale偶no艣ci" as a header, and english version of it in a tooltip (like on the screenshot, but "reversed").
Let me know if that will be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I guess that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weryfikowa膰 i adnotowa膰
once more you used 'weryfikowa膰' instead of 'walidowa膰' which would be more consistent with the rest of your translation.
'Walidacja' is an actual word in polish, though I agree that using it as a verb (walidowa膰) is not something you see often.
Maybe this should be: 'podda膰 walidacji'
This way it could be both correct and more pleasant to look at. 馃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree that "podda膰 walidacji" sounds much better, thanks!