🌐 Add Polish translation for docs/pl/docs/features.md
#5348
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13934 -35
=========================================
- Hits 13969 13934 -35 ☔ View full report in Codecov by Sentry. |
|
📝 Docs preview for commit 0b1f548 at: https://63150d6480fe05342d8f1dd3--fastapi.netlify.app |
docs/pl/docs/features.md
Outdated
|
|
||
| Wszystko zbudowane jako narzędzia i komponenty wielokrotnego użytku, które można łatwo zintegrować z systemami, magazynami oraz bazami danych - relacyjnymi, NoSQL, itp. | ||
|
|
||
| ### Dependency Injection |
There was a problem hiding this comment.
While I agree that the name Dependency Injection is so well known that most likely even non-english speaking programmers are likely to be familiar with it and the feature itself is a key feature of FastAPI, I still think that the term Wstrzykiwanie Zależności should be used here. It's well established in polish literature.
I would suggest going with:
Wstrzykiwanie Zależności (Dependency Injection)
or the other way around:
Dependency Injection (Wstrzykiwanie Zależności)
There was a problem hiding this comment.
I was thinking about it for a while, but then I noticed that in some other language versions of documentation it's translated, and in others it's not.
So I've decided to go with the same pattern as in spanish translation, which is using "Dependency Injection" as a header but in the next line is adding title for another occurrence, but with explaination in spanish:
My reasoning for it was that "Dependency Injection" is definitely used more often in web development industry than "Wstrzykiwanie Zależności", but anyway, to not leaving it untranslated, I've provided translation for it in the next line.
But I agree with you, I'll go with just "Wstrzykiwanie Zależności" as a header, and english version of it in a tooltip (like on the screenshot, but "reversed").
Let me know if that will be fine.
docs/pl/docs/features.md
Outdated
| * Walidacja **złożonych struktur**: | ||
| * Wykorzystanie hierarchicznych modeli Pydantic, Pythonowego modułu `typing` zawierającego `List`, `Dict`, itp. | ||
| * Walidatory umożliwiają jasne i łatwe definiowanie, sprawdzanie złożonych struktur danych oraz dokumentowanie ich jako JSON Schema. | ||
| * Możesz mieć głęboko **zagnieżdżone obiekty JSON** i wszystkie je weryfikować i adnotować. |
There was a problem hiding this comment.
weryfikować i adnotować
once more you used 'weryfikować' instead of 'walidować' which would be more consistent with the rest of your translation.
'Walidacja' is an actual word in polish, though I agree that using it as a verb (walidować) is not something you see often.
Maybe this should be: 'poddać walidacji'
This way it could be both correct and more pleasant to look at. 🤔
There was a problem hiding this comment.
Yes, I agree that "poddać walidacji" sounds much better, thanks!
|
📝 Docs preview for commit 19724d0 at: https://63274c10c2a82150c76298da--fastapi.netlify.app |
|
I applied the changes, thank you for review @eryknn! |
|
Hi @eryknn! If everything looks good to you, can you approve this PR? |
|
📝 Docs preview for commit 093546d at: https://639cda51e97dd300a9989dbb--fastapi.netlify.app |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
📝 Docs preview for commit 834ad80 at: https://64943579681c051e3e29670d--fastapi.netlify.app |
|
Awesome, thank you @mbroton! 🍰 And thanks for the reviews @Mordson, @Valaraucoo, @eryknn 🙇 ☕ |
Relates to #3169
This translates
docs/features.mdinto polish