Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for docs/ja/docs/advanced/index.md #5043

Merged
merged 12 commits into from Jul 14, 2022
Merged

🌐 Add Japanese translation for docs/ja/docs/advanced/index.md #5043

merged 12 commits into from Jul 14, 2022
+25 −0

Conversation

wakabame
Copy link
Contributor

@wakabame wakabame commented Jun 16, 2022 •
edited

Relates to #1572
This PR translates advanced/index.md.

Since 18 months have passed since the review but the PR: #2080 is still intact, the wording was changed and the PR was re-created.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 07da600 at: https://62ab57073e1dd332901e53cd--fastapi.netlify.app

@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited

Codecov Report

Merging #5043 (64af732) into master (fb26c1e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5043   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13684     13684           
=========================================
  Hits         13684     13684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb26c1e...64af732. Read the comment docs.

tokusumi
tokusumi suggested changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution.
I upvote to recreate a PR that author does not respond for a long time.

Here are some suggestions to improve translations.

docs/ja/docs/advanced/index.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/index.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/index.md Outdated
!!! tip "豆知識"
以降のセクションは、 **必ずしも"応用編"ではありません**.

ユースケースによっては、中から解決策を見つけることができるでしょう。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ユースケースによっては、中から解決策を見つけることができるでしょう。
様々なユースケースに応じたソリューションも説明します。

is this not better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhh,,, I feel it's too mean-spirited.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt that "中から" made the sentence unnatural, so I modified it as follows, as long as it does not deviate too much from the original text. What do you think? cbff1ff

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the meaning, but that may be because I have read both the original and the translated text many times.
To improve this, we need the opinions of other reviewers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current one looks no problem to me, but would be a little straightforward to point them -> the next sections.

< ユースケースによっては、解決策を見つけることができるでしょう。
> ユースケースによっては、その中から解決策を見つけられるかもしれません。

docs/ja/docs/advanced/index.md Outdated Show resolved Hide resolved
@wakabame @tokusumi
Update docs/ja/docs/advanced/index.md
db3c521 
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit db3c521 at: https://62ae14697e4d50290e5e9568--fastapi.netlify.app

wakabame and others added 2 commits June 19, 2022 03:15
@wakabame @tokusumi
Update docs/ja/docs/advanced/index.md
9450cb6 
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@wakabame @tokusumi
Update docs/ja/docs/advanced/index.md
1958de3 
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 1958de3 at: https://62ae1705d39be72dddd492f0--fastapi.netlify.app

@wakabame
Copy link
Contributor Author

@tokusumi
thank you for your comments. I have reviewed the points raised and made some changes. Could you please review them again?

@github-actions
Copy link
Contributor

📝 Docs preview for commit cbff1ff at: https://62ae18386fa84c2d17584267--fastapi.netlify.app

tokusumi
tokusumi approved these changes Jun 19, 2022
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your great work!
I expect others review especially for line 12.

sh0nk
sh0nk approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@sh0nk sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left my humble opinion, but looks enough good!

docs/ja/docs/advanced/index.md Outdated
!!! tip "豆知識"
以降のセクションは、 **必ずしも"応用編"ではありません**.

ユースケースによっては、中から解決策を見つけることができるでしょう。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current one looks no problem to me, but would be a little straightforward to point them -> the next sections.

< ユースケースによっては、解決策を見つけることができるでしょう。
> ユースケースによっては、その中から解決策を見つけられるかもしれません。

@wakabame
Copy link
Contributor Author

@sh0nk @tokusumi
Thank you for your accurate suggestions! I fixed them

@github-actions
Copy link
Contributor

📝 Docs preview for commit 7fbae0f at: https://62b7a171232d3456999e9af0--fastapi.netlify.app

@tiangolo
Copy link
Owner

Awesome, thank you @wakabame! 🍰 And thanks for pointing out the other PR, so that I can close it 🤓

And thanks for the reviews @sh0nk and @tokusumi ! 🍪

@tiangolo tiangolo enabled auto-merge (squash) July 14, 2022 11:33
@tiangolo tiangolo merged commit 80cb57e into tiangolo:master Jul 14, 2022
@tiangolo tiangolo mentioned this pull request Jul 14, 2022
Closed
@wakabame wakabame deleted the translation/add-japanese-doc-Advanced-index branch July 14, 2022 16:33
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
@wakabame @amazyra
@tokusumi @tiangolo @JeanArhancet
🌐 Add Japanese translation for docs/ja/docs/advanced/index.md (tian…
f5cdf70 
…golo#5043)

Co-authored-by: Amazyra <yamaguchi.tatsuya.27a@gmail.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0nk sh0nk sh0nk approved these changes

@tokusumi tokusumi tokusumi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wakabame @tiangolo @sh0nk @tokusumi @amazyra