Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Chinese translation for docs/zh/docs/advanced/wsgi.md #4505

Merged
merged 8 commits into from Oct 31, 2022
Merged

🌐 Add Chinese translation for docs/zh/docs/advanced/wsgi.md #4505

merged 8 commits into from Oct 31, 2022

Conversation

ASpathfinder
Copy link
Contributor

as title

@ASpathfinder ASpathfinder changed the title add Chinese translation for docs/advanced/wsgi.md Add Chinese translation for docs/advanced/wsgi.md Feb 7, 2022
@tiangolo tiangolo changed the title Add Chinese translation for docs/advanced/wsgi.md 🌐 Add Chinese translation for docs/zh/docs/advanced/wsgi.md May 10, 2022
@tiangolo tiangolo added lang-all Translations lang-zh Chinese translations awaiting-review labels May 10, 2022
@github-actions github-actions bot mentioned this pull request May 10, 2022
Closed
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (333b205) compared to base (e13df8e).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #4505   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13946     13946           
=========================================
  Hits         13946     13946

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 17aa22f at: https://6279dec55502b82b50a0c200--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9da306a at: https://627cc0eb6071c339fd8a1727--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

📝 Docs preview for commit 0109449 at: https://6316f0de6702a7183589da73--fastapi.netlify.app

Jedore
Jedore suggested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@Jedore Jedore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a bit optimization.

@github-actions
Copy link
Contributor

📝 Docs preview for commit a7c362f at: https://6348e4b8058c245879f1485b--fastapi.netlify.app

Jedore
Jedore reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Jedore Jedore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review

docs/zh/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/zh/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/zh/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/zh/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit eeba8de at: https://634f56d6b580d6228bbaebf8--fastapi.netlify.app

@ASpathfinder @Jedore
Apply suggestions from code review
333b205 
Fix some translation errors

Co-authored-by: Jeodre <jedore_fight@189.cn>
ASpathfinder
ASpathfinder commented Oct 19, 2022
View reviewed changes
Copy link
Contributor Author

@ASpathfinder ASpathfinder left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions, @Jedore

@github-actions
Copy link
Contributor

📝 Docs preview for commit 333b205 at: https://634f58fc3236be2e44352f01--fastapi.netlify.app

@tiangolo
Copy link
Owner

Great, thanks @ASpathfinder! 🚀

And thanks for the reviews @Jedore and @1320555911! 🎉

@tiangolo tiangolo merged commit a26a3c1 into tiangolo:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jedore Jedore Jedore approved these changes

@1320555911 1320555911 1320555911 approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-zh Chinese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ASpathfinder @tiangolo @Jedore @1320555911 @KellyAlsa