New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for `docs/ja/docs/advanced/nosql-databases.md` #4205

Merged

tiangolo merged 6 commits into tiangolo:master from sUeharaE4:add-ja-translate-advanced-nosqldatabases

Aug 18, 2022

+157 −0

Contributor

sUeharaE4 commented Nov 23, 2021

Relates to #1572

This PR translates advanced/nosql-databases.md.

I left "databases" in the page title as it is because there is no word for the plural of database in Japanese.
This is my first pull request, so I apologize if there are any problems. I would appreciate it if you could check it.

sUeharaE4 added 2 commits

November 23, 2021 21:34


          Add Japanese translation for - docs/ja/docs/advanced/nosql-databases.md

f5f4272


          Update: remove redundant expressions

96bd631

tiangolo changed the title ~~Add Japanese translation for Advanced - NoSQL Databases~~ 🌐 Add Japanese translation for docs/ja/docs/advanced/nosql-databases.md

tiangolo added awaiting-review lang-all lang-ja labels

github-actions bot mentioned this pull request

Japanese Translation #1572

Closed

Contributor

github-actions bot commented Dec 8, 2021

📝 Docs preview for commit 96bd631 at: https://61b0caec4bb4cd2a61ab32e4--fastapi.netlify.app

codecov bot commented Dec 8, 2021 •

edited

Codecov Report

Merging #4205 (0b29c08) into master (1876ebc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13672     13672           
=========================================
  Hits         13672     13672

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1876ebc...0b29c08. Read the comment docs.

dimaqq approved these changes

View reviewed changes

Contributor

dimaqq left a comment

I'm not a native speaker, but this seems solid!

wakabame approved these changes

View reviewed changes

Contributor

wakabame left a comment

Excellent work!!

Contributor

dimaqq commented Jun 16, 2022

@tiangolo this should be ready, let's merge!

github-actions bot added approved-2 and removed awaiting-review labels

tokusumi suggested changes

View reviewed changes

Contributor

tokusumi left a comment

Thank you for great work!!!
I'd like to suggests the followings, although already you've gotten enough approve.

docs/ja/docs/advanced/nosql-databases.md Outdated

		@@ -0,0 +1,155 @@
		# NoSQL (分散 / ビッグデータ) Databases

		FastAPI はあらゆる <abbr title="分散データベース (Big Data), や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。

Contributor

tokusumi Jun 16, 2022

Suggested change

      
            **FastAPI** はあらゆる <abbr title="分散データベース (Big Data), や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。
          
            **FastAPI** はあらゆる <abbr title="分散データベース (Big Data)や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。

Contributor

tokusumi Jun 16, 2022

we could omit "," or put it after "や"

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL3

docs/ja/docs/advanced/nosql-databases.md Outdated


		この関数では:

		* Couchbase クラスタ(1台の場合もあるでしょう)に接続し

Contributor

tokusumi Jun 16, 2022

Here too rough writing are used than other sections. I suggest to delete some "し" and "して" at all lines.

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied arround here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL48

docs/ja/docs/advanced/nosql-databases.md Outdated


		## Pydantic モデルの作成

		Couchbaseのdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルにすることが出来ます。

Contributor

tokusumi Jun 16, 2022

Suggested change

      
            **Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルにすることが出来ます。
          
            **Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルに出来ます。

Suggesting shorten expression at the end of a sentence.

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL63

docs/ja/docs/advanced/nosql-databases.md Outdated

+              {!../../../docs_src/nosql_databases/tutorial001.py!}
+              ```
+              このモデルは*path operation*で利用できる関数で使用するので`hashed_password`はモデルに含めません。

Contributor

tokusumi Jun 16, 2022

Suggested change

      
            このモデルは*path operation*で利用できる関数で使用するので`hashed_password`はモデルに含めません。
          
            このモデルは*path operation*に使用するので、`hashed_password`は含めません。

This is difficult to translate. Here, path operation (function) refer to read_user function.

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL73

docs/ja/docs/advanced/nosql-databases.md Outdated

+              {!../../../docs_src/nosql_databases/tutorial001.py!}
+              ```
+              !!! note

Contributor

tokusumi Jun 16, 2022 •

edited

Suggested change

      
            !!! note
          
            !!! note "備考"

Unified at translation tracking issue

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL87

docs/ja/docs/advanced/nosql-databases.md Outdated


		それでは次の関数を作成しましょう:

		* username を取得して

Contributor

tokusumi Jun 16, 2022

Same as above suggestion. Deleting "して" or Replacing with "する" are better.

Contributor Author

sUeharaE4 Jun 18, 2022 •

edited

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL96

docs/ja/docs/advanced/nosql-databases.md

+              {!../../../docs_src/nosql_databases/tutorial001.py!}
+              ```
+              ### f-strings

Contributor

tokusumi Jun 16, 2022

Suggested change

      
            ### f-strings
          
            ### f-strings

Maybe newline needs after heading.

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL96

docs/ja/docs/advanced/nosql-databases.md Outdated


		## "document type" として利用する定数の定義

		documentで利用する固定のフィールド`type`を用意しておきます。

Contributor

tokusumi Jun 16, 2022

Suggested change

      
            documentで利用する固定のフィールド`type`を用意しておきます。
          
            documentで利用する固定の`type`フィールドを用意しておきます。

More easier to read?

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL28

tokusumi reviewed

View reviewed changes

docs/ja/docs/advanced/nosql-databases.md Outdated

+              * **ArangoDB**
+              * **ElasticSearch** など。
+              !!! 豆知識

Contributor

tokusumi Jun 16, 2022

Suggested change

      
            !!! 豆知識
          
            !!! tip "豆知識"

I'm not sure but maybe this is (or was) right syntax.

Contributor Author

sUeharaE4 Jun 18, 2022

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL15

sUeharaE4 and others added 3 commits

June 18, 2022 16:24


          Update: Apply suggestions from review


          Merge branch 'master' into add-ja-translate-advanced-nosqldatabases

2cbea51


          🎨 [pre-commit.ci] Auto format from pre-commit.com hooks

99a1523

Contributor

github-actions bot commented Jun 18, 2022

📝 Docs preview for commit 99a1523 at: https://62ad80850151d34b7adb7eb3--fastapi.netlify.app

tokusumi suggested changes

View reviewed changes

docs/ja/docs/advanced/nosql-databases.md Outdated Show resolved Hide resolved


          Update: Apply suggestions from review

0b29c08

Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>

Contributor

github-actions bot commented Jun 18, 2022

📝 Docs preview for commit 0b29c08 at: https://62add7c6b9dd507f67334965--fastapi.netlify.app

tokusumi approved these changes

View reviewed changes

Contributor

tokusumi left a comment

LGTM

Owner

tiangolo commented Aug 18, 2022

Thanks for the contribution @sUeharaE4! 🍰

And thank you for the reviews @dimaqq, @wakabame, and @tokusumi! ☕

tiangolo merged commit e23fa40 into tiangolo:master

JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request


          🌐 Add Japanese translation for `docs/ja/docs/advanced/nosql-databases…

4208bb8

….md` (tiangolo#4205)

Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment