✨ Add support for Trio via AnyIO #3372

graingert · 2021-06-14T22:47:29Z

Fixes #310

Codecov Report

Merging #3372 (7c19efb) into master (4d26fa5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #3372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          410       409    -1     
  Lines        10281     10264   -17     
=========================================
- Hits         10281     10264   -17

Impacted Files	Coverage Δ
docs_src/async_tests/test_main.py	`100.00% <100.00%> (ø)`
fastapi/concurrency.py	`100.00% <100.00%> (ø)`
fastapi/dependencies/utils.py	`100.00% <100.00%> (ø)`
tests/test_tutorial/test_async_tests/test_main.py	`100.00% <100.00%> (ø)`
.../test_tutorial/test_websockets/test_tutorial002.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d26fa5...7c19efb. Read the comment docs.

github-actions · 2021-07-19T19:24:07Z

📝 Docs preview for commit 327cfd0 at: https://60f5d124cc234109837cf232--fastapi.netlify.app

github-actions · 2021-07-19T19:39:06Z

📝 Docs preview for commit 17ed7ea at: https://60f5d4a51fb0c609691189c3--fastapi.netlify.app

github-actions · 2021-07-20T11:39:35Z

📝 Docs preview for commit 0040972c9f53817f64e7b401c9a62b2d32cbae69 at: https://60f6b586a187b6c97290d32d--fastapi.netlify.app

github-actions · 2021-07-20T11:42:33Z

📝 Docs preview for commit 7af1e84 at: https://60f6b6716548bbcdf708fea8--fastapi.netlify.app

github-actions · 2021-07-24T09:32:36Z

📝 Docs preview for commit 0c7195f at: https://60fbddc1d5d642d3e7109471--fastapi.netlify.app

github-actions · 2021-08-03T08:47:48Z

📝 Docs preview for commit ada7c74 at: https://61090286422fcaca80ac71ea--fastapi.netlify.app

espetro · 2021-08-17T16:29:58Z

Hi! Thanks for such an amazing work 🙌🏼 , I cannot wait to try trio with FastAPI. How are we supposed to enable it?

graingert · 2021-08-17T16:34:42Z

Hi! Thanks for such an amazing work 🙌🏼 , I cannot wait to try trio with FastAPI. How are we supposed to enable it?

You'll need to pip install this branch from git

ArcLightSlavik · 2021-08-17T17:08:04Z

Hi! Thanks for such an amazing work 🙌🏼 , I cannot wait to try trio with FastAPI. How are we supposed to enable it?

You'll need to pip install this branch from git

Antony to the rescue 😉 https://www.youtube.com/watch?v=AQrskWh-F5E

dhirschfeld · 2021-08-24T21:39:05Z

You'll need to pip install this branch from git

As a conda user it would be great to have this in a release (conda-forge only package pypi releases).
@graingert has been keeping this up-to-date with master - is there anything stopping it being merged?

adriangb · 2021-08-24T21:41:56Z

is there anything stopping it being merged?

I think the only thing missing is review from @tiangolo

github-actions · 2021-09-24T17:11:23Z

📝 Docs preview for commit a539aa6 at: https://614e064a38c62108f4aa04d4--fastapi.netlify.app

…lity

to simplify migrations for people. I'll make a release with this, and then a new release with Starlette 0.16.0

github-actions · 2021-10-06T14:41:02Z

📝 Docs preview for commit 51c5edd at: https://615db50772917d315e65389c--fastapi.netlify.app

github-actions · 2021-10-06T15:02:40Z

📝 Docs preview for commit 9b52693 at: https://615dba62e9b158384170e013--fastapi.netlify.app

github-actions · 2021-10-06T15:14:09Z

📝 Docs preview for commit 96cb5b2 at: https://615dbd0e3c862141e444a469--fastapi.netlify.app

later it will be required by Starlette 0.16.0

github-actions · 2021-10-06T15:21:05Z

📝 Docs preview for commit 7c19efb at: https://615dbeb18d64483d2c550e56--fastapi.netlify.app

tiangolo · 2021-10-06T15:22:29Z

Thanks for all the work @graingert! 👏 🍰

I refactored a couple of things, to keep the same style of import/reexports in the rest of the places (without __all__). And I refactored the re-implementation of asyncio.gather() to simplify it and inline it a bit as the utility functions are not re-exported either way.

I also pinned Starlette to the minimum version that supports AnyIO (0.15.0) to make it easier for others to gradually migrate. I'll make a release with this. And then I'll upgrade Starlette and make another release.

This will be available in a couple of hours in FastAPI 0.69.0. 🎉

graingert · 2021-10-07T09:07:59Z

I also pinned Starlette to the minimum version that supports AnyIO (0.15.0) to make it easier for others to gradually migrate.

You should definitely pin to 0.16.0, the breaking change is around the TestClient(async_backend) kwarg which didn't exist before 0.15.0

graingert added 2 commits February 10, 2021 23:19

configure strict pytest options

6cc34f1

open/close files with with

9f50ab2

ArcLightSlavik approved these changes Jun 15, 2021

View reviewed changes

fastapi/concurrency.py Show resolved Hide resolved

graingert force-pushed the anyio branch from f002f2c to 278fec9 Compare June 23, 2021 10:01

Kludex reviewed Jun 23, 2021

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Kludex mentioned this pull request Jun 23, 2021

Update starlette to 0.15.0 #3399

Closed

support trio via anyio with starlette 0.15.0

388b5c9

graingert force-pushed the anyio branch from 278fec9 to c81be40 Compare June 23, 2021 15:46

graingert added 3 commits June 23, 2021 17:34

WebSocketDisconnect only happens in websocket_connect context manager

33ffaa7

* `TestClient.websocket_connect()` now must be used as a context manager: https://github.com/encode/starlette/blame/119c427474a45bd1297f5adcde864b2874dd8c4f/docs/release-notes.md#L13

drop pytest-asyncio dep

15b9f76

Merge branch 'configure-strict-pytest' of github.com:graingert/fastap…

0349712

…i into anyio

graingert force-pushed the anyio branch from 7a9e30e to 0349712 Compare June 23, 2021 16:36

Merge branch 'master' into anyio

06f543d

graingert commented Jul 19, 2021

View reviewed changes

pyproject.toml Show resolved Hide resolved

Update pyproject.toml

3b689b7

graingert commented Jul 19, 2021

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

graingert added 2 commits July 19, 2021 08:21

bump anyio[trio]

0622860

Merge branch 'master' into anyio

327cfd0

increase coverage with pytest.fail() # pragma: no cover

17ed7ea

adriangb mentioned this pull request Jul 20, 2021

Add startup/shutdown dependencies and dependency caching lifespan control #3516

Closed

graingert added 2 commits July 20, 2021 12:39

drop async_generator and async_exit_stack deps

9b14e4a

drop aiofiles

7af1e84

graingert force-pushed the anyio branch from 0040972 to 7af1e84 Compare July 20, 2021 11:39

alonme mentioned this pull request Jul 23, 2021

🌐 Remove translation docs references to aiofiles as it's no longer needed since AnyIO #3594

Merged

Merge branch 'master' into anyio

0c7195f

Merge branch 'master' of git://github.com/tiangolo/fastapi into anyio

ada7c74

Merge branch 'master' of git://github.com/tiangolo/fastapi into anyio

a539aa6

tiangolo added 5 commits October 6, 2021 16:21

✏️ Fix typo

bcfddbe

⏪ Revert import/reexport style in concurrency to simplify maintainabi…

702aca3

…lity

♻️ Simplify and inline re-implementation of asyncio.gather()

580c65b

📌 Pin Starlette to the gradual next version, minimum that supports AnyIO

861f71d

to simplify migrations for people. I'll make a release with this, and then a new release with Starlette 0.16.0

🔀 Merge master

51c5edd

🔇 Add pytest filterwarning needed by AnyIO in Python 3.9

9b52693

🔀 Merge master

96cb5b2

➕ Add contextlib2 as a direct dependency during the migration

7c19efb

later it will be required by Starlette 0.16.0

tiangolo changed the title ~~support trio via anyio~~ ✨ Add support for Trio via AnyIO Oct 6, 2021

tiangolo merged commit 11d0a08 into tiangolo:master Oct 6, 2021

graingert deleted the anyio branch October 6, 2021 15:33

JonasKs mentioned this pull request Oct 16, 2021

Support trio Intility/fastapi-azure-auth#31

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add support for Trio via AnyIO #3372

✨ Add support for Trio via AnyIO #3372

graingert commented Jun 14, 2021

graingert commented Jun 26, 2021 •

edited

graingert commented Jun 29, 2021

codecov bot commented Jul 19, 2021 •

edited

github-actions bot commented Jul 19, 2021

github-actions bot commented Jul 19, 2021

github-actions bot commented Jul 20, 2021

github-actions bot commented Jul 20, 2021

github-actions bot commented Jul 24, 2021

github-actions bot commented Aug 3, 2021

espetro commented Aug 17, 2021 •

edited

graingert commented Aug 17, 2021

ArcLightSlavik commented Aug 17, 2021

dhirschfeld commented Aug 24, 2021

adriangb commented Aug 24, 2021

github-actions bot commented Sep 24, 2021

github-actions bot commented Oct 6, 2021

github-actions bot commented Oct 6, 2021

github-actions bot commented Oct 6, 2021

github-actions bot commented Oct 6, 2021

tiangolo commented Oct 6, 2021

graingert commented Oct 7, 2021

✨ Add support for Trio via AnyIO #3372

✨ Add support for Trio via AnyIO #3372

Conversation

graingert commented Jun 14, 2021

graingert commented Jun 26, 2021 • edited

graingert commented Jun 29, 2021

codecov bot commented Jul 19, 2021 • edited

Codecov Report

github-actions bot commented Jul 19, 2021

github-actions bot commented Jul 19, 2021

github-actions bot commented Jul 20, 2021

github-actions bot commented Jul 20, 2021

github-actions bot commented Jul 24, 2021

github-actions bot commented Aug 3, 2021

espetro commented Aug 17, 2021 • edited

graingert commented Aug 17, 2021

ArcLightSlavik commented Aug 17, 2021

dhirschfeld commented Aug 24, 2021

adriangb commented Aug 24, 2021

github-actions bot commented Sep 24, 2021

github-actions bot commented Oct 6, 2021

github-actions bot commented Oct 6, 2021

github-actions bot commented Oct 6, 2021

github-actions bot commented Oct 6, 2021

tiangolo commented Oct 6, 2021

graingert commented Oct 7, 2021

graingert commented Jun 26, 2021 •

edited

codecov bot commented Jul 19, 2021 •

edited

espetro commented Aug 17, 2021 •

edited