🌐 Remove translation docs references to aiofiles as it's no longer needed since AnyIO #3594

alonme · 2021-07-23T12:13:18Z

2022-05-09 Edit (by @tiangolo): the scope of this PR was changed to remove docs/translations references to aiofiles as the other intended changes were covered in other PRs.

Original description

Related to #3589

This Starlette PR (https://github.com/encode/starlette/pull/1158/files#) solves the issue from #3589.

Updating starlette to solve this issue in FastAPI

alonme · 2021-07-23T12:15:43Z

PR #3372 also updates starlette, however it seems to take a long time to merge as it includes many other changes.

I hope we can merge this smaller branch quicker to resolve #3589 .

I copied the test fix from #3372 to prevent conflicts later

If its easier for any reason - the same can be achieved by updating to 0.15.0

graingert

The docs about aiofiles will need removing

alonme · 2021-07-24T13:03:28Z

@graingert - Removed aiofiles and tested it still works for FileResponse and StaticFiles

graingert · 2021-07-24T13:16:22Z

what do you think about the contextlib2 backport changes? Starlette depends on it on python3.6 so FastAPI doesn't need the async_generator or async_exit_stack deps anymore

alonme · 2021-07-24T13:51:11Z

@graingert - Not to familiar with these, aren't these more related to the trio/anyio change? can we remove the backports without changes from #3372 ?

graingert · 2021-07-24T13:52:40Z

@alonme not directly related to anyio/trio no

alonme · 2021-07-24T14:18:05Z

@graingert - Thanks, backported these changes from the other PR.

alonme · 2021-07-27T07:43:57Z

Can anyone enable tests?

Mause · 2021-07-27T07:49:09Z

@tiangolo is the only person with merge and test run access unfortunately

GuySpotnix · 2021-08-04T11:25:20Z

+1
Please merge #3589

alonme · 2021-08-11T18:31:04Z

resolves #3674

graingert · 2021-08-11T18:55:23Z

PR #3372 also updates starlette, however it seems to take a long time to merge as it includes many other changes.

I'm not sure which changes in #3372 would delay the PR

alonme · 2021-08-11T19:09:24Z

@graingert, me neither - it just seemed to me that it wasn't getting merge quickly at the time.
This pr was much smaller than #3372 , however after your rightful comments they aren't that different anymore.
This is still simpler, and i hoped it would be possible to merge it quickly as it fixes a bug which i think is pretty bad.

graingert · 2021-08-11T19:11:21Z

I was considering adding wait_all to starlette at starlette.concurrency:wait_all as it's the most complicated bit of the changes imho

alonme · 2021-08-11T19:11:35Z

@tiangolo - Can we proceed with one of the PR's?

graingert · 2021-08-11T19:19:14Z

It would be good to get a release with a new Starlette that supports py3.6-py3.10 before the December EOL of Python 3.6

alonme · 2021-09-22T11:57:29Z

@tiangolo - can we please go forward with this? or at least get a comment?
There are at least 2 issues that this will fix, and another project that waits for features from starlette 0.16

thanks

brnosouza · 2021-09-27T14:25:58Z

any update on this?

stephan-hesselmann-by · 2021-09-27T14:31:05Z

I have to say this is not a good look for the project. Not only this PR but many others are stalled with no comments from the maintainer. Actually it seems like the project is unmaintained.

Mause · 2021-09-27T15:30:14Z

@stephan-hesselmann-by you are correct unfortunately, this project is effectively abandoned

billcrook · 2021-09-27T15:40:18Z

@stephan-hesselmann-by you are correct unfortunately, this project is effectively abandoned

💯 I'm considering dropping down to starlette directly esp considering all the shims and overrides I'm putting into place to get everything how I want it (custom error responses, finer grained transaction control, singleton dependencies, #1359, etc...). API doc is nice I suppose?

tiangolo · 2021-09-27T17:36:35Z

The project is not abandoned at all.

In fact, one of the main things wanted in the existing PRs and issues was a way to improve how models are defined for databases and Pydantic, and support for the latest versions of SQLAlchemy, so I spent months building https://github.com/tiangolo/sqlmodel, which is made for FastAPI. 🚀

I have a lot of pending PRs to review and a lot of things in the backlog, and I'm covering them all gradually and with the minimum disruption possible. This also applies to all my Docker images, that for example, now support Python 3.9, all of them.

I'm carefully reviewing each PR and issue myself, and I have been changing my whole work-life in the last months, including dealing with visas and German bureaucracy to be able to dedicate much more time to all my open source projects.

Also, the comments claiming that it is abandoned were made 2 hours ago, when the last commit improving the HTTPS guide was done 3 hours ago. 🤦 😞

The improved HTTPS guide is part of an effort into improving the information about deployments and how (and when) to use which Docker images, etc. So that will come soon too. 🎉

adriangb · 2021-09-27T17:52:14Z

Thank you for the response @tiangolo! I'm very glad this project is alive 😄

First off, I think it is amazing the amount and quality of work you are able to do as one person. That said, I do think it might be best for the health of the projects to build teams by giving repeat contributors that have shown to produce high quality work more privileges, that way they can get PRs into a good state (by providing feedback to PR authors) before you even have to look at them, even if you are still the one giving the final ✅ . This can also be codified, e.g. w/ CODEOWNERS files.

v3ss0n · 2021-10-02T00:00:16Z

The project is not abandoned at all.

In fact, one of the main things wanted in the existing PRs and issues was a way to improve how models are defined for databases and Pydantic, and support for the latest versions of SQLAlchemy, so I spent months building https://github.com/tiangolo/sqlmodel, which is made for FastAPI. rocket

I have a lot of pending PRs to review and a lot of things in the backlog, and I'm covering them all gradually and with the minimum disruption possible. This also applies to all my Docker images, that for example, now support Python 3.9, all of them.

I'm carefully reviewing each PR and issue myself, and I have been changing my whole work-life in the last months, including dealing with visas and German bureaucracy to be able to dedicate much more time to all my open source projects.

Also, the comments claiming that it is abandoned were made 2 hours ago, when the last commit improving the HTTPS guide was done 3 hours ago. facepalm disappointed

The improved HTTPS guide is part of an effort into improving the information about deployments and how (and when) to use which Docker images, etc. So that will come soon too. tada

Awesome to hear from you @tiangolo . I am using fastapi for almsot a year now. And the popularity keep rising.
I am sure FastAPI would be benefit from Community Driven development , since the project is growing faster for one person to manage, have you consider starting a foundation / organization and appointing good contributors to help you review code / merge?

That would make FastAPI grow bigger and FastAPI is really the web framework python deserves.

brnosouza · 2021-10-07T11:32:53Z

@alonme I think you need to rebase, mainly because a similar PR was merged and contains a few updates

agronholm · 2021-10-07T12:00:40Z

Does this PR add anything compared to the merged one?

alonme · 2021-10-07T12:15:42Z

@brnosouza - thanks, will get to that a bit later
@agronholm - from what i have seen, the update is only to starlette 0.15.0, and not 0.16.0

so my update also accounts for the aiofiles documentation @tiangolo described here #2899 (comment)

alonme · 2021-10-07T20:57:34Z

rebased

alonme · 2021-10-07T21:05:52Z

ok, now i see @tiangolo created his own PR to update to 0.16.0

So this only includes docs fix

codecov · 2022-05-10T01:03:30Z

Codecov Report

Merging #3594 (6232e44) into master (8a353ab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #3594   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13629     13629           
=========================================
  Hits         13629     13629

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a353ab...6232e44. Read the comment docs.

github-actions · 2022-05-10T01:05:42Z

📝 Docs preview for commit 6232e44 at: https://6279ba36fab0da14c006f463--fastapi.netlify.app

tiangolo · 2022-05-10T01:07:13Z

Thanks for the discussion everyone, this was solved a while ago in another PR and has been available for a while in recent releases.

Given that, I reduced the scope of this particular PR to remove the docs/translations references to aiofiles. Thanks for the interest and discussion you all! ☕

…eded since AnyIO (tiangolo#3594) Co-authored-by: AlonMenczer <alonm@spotnix.io> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>

alonme changed the title ~~Update starlette version~~ Update starlette version - solves #3589 Jul 23, 2021

graingert suggested changes Jul 24, 2021

View reviewed changes

This was referenced Aug 10, 2021

Unable to install a library (pact-python) which depends on fastapi because of starlette version conflict #3674

Closed

Upgrade Starlette to version 0.16.0 #3681

Closed

mcous mentioned this pull request Sep 1, 2021

refactor(robot_server,api): do not use ThreadManager with ProtocolEngine Opentrons/opentrons#8278

Merged

4 tasks

Update starlette version

69879d8

Remove aiofiles from docs and deps

a798f14

alonme force-pushed the update-starlette-version branch from 60982db to 750e245 Compare October 7, 2021 20:56

remove tr docs

6e32a7f

alonme force-pushed the update-starlette-version branch from eb28fc7 to 6e32a7f Compare October 7, 2021 21:00

Merge branch 'master' into update-starlette-version

a45568f

banuni approved these changes Oct 12, 2021

View reviewed changes

Merge branch 'master' into update-starlette-version

6232e44

tiangolo changed the title ~~Update starlette version - solves #3589~~ 🌐 Remove translation docs references to aiofiles as it's no longer needed since AnyIO May 10, 2022

tiangolo merged commit c0d6865 into tiangolo:master May 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌐 Remove translation docs references to aiofiles as it's no longer needed since AnyIO #3594

🌐 Remove translation docs references to aiofiles as it's no longer needed since AnyIO #3594

alonme commented Jul 23, 2021 •

edited by tiangolo

alonme commented Jul 23, 2021 •

edited

graingert left a comment

alonme commented Jul 24, 2021

graingert commented Jul 24, 2021

alonme commented Jul 24, 2021

graingert commented Jul 24, 2021

alonme commented Jul 24, 2021

alonme commented Jul 27, 2021

Mause commented Jul 27, 2021

GuySpotnix commented Aug 4, 2021

alonme commented Aug 11, 2021

graingert commented Aug 11, 2021

alonme commented Aug 11, 2021 •

edited

graingert commented Aug 11, 2021

alonme commented Aug 11, 2021

graingert commented Aug 11, 2021

alonme commented Sep 22, 2021

brnosouza commented Sep 27, 2021

stephan-hesselmann-by commented Sep 27, 2021

Mause commented Sep 27, 2021

billcrook commented Sep 27, 2021

tiangolo commented Sep 27, 2021

adriangb commented Sep 27, 2021

v3ss0n commented Oct 2, 2021 •

edited

brnosouza commented Oct 7, 2021

agronholm commented Oct 7, 2021

alonme commented Oct 7, 2021

alonme commented Oct 7, 2021

alonme commented Oct 7, 2021

codecov bot commented May 10, 2022 •

edited

github-actions bot commented May 10, 2022

tiangolo commented May 10, 2022

🌐 Remove translation docs references to aiofiles as it's no longer needed since AnyIO #3594

🌐 Remove translation docs references to aiofiles as it's no longer needed since AnyIO #3594

Conversation

alonme commented Jul 23, 2021 • edited by tiangolo

Original description

alonme commented Jul 23, 2021 • edited

graingert left a comment

Choose a reason for hiding this comment

alonme commented Jul 24, 2021

graingert commented Jul 24, 2021

alonme commented Jul 24, 2021

graingert commented Jul 24, 2021

alonme commented Jul 24, 2021

alonme commented Jul 27, 2021

Mause commented Jul 27, 2021

GuySpotnix commented Aug 4, 2021

alonme commented Aug 11, 2021

graingert commented Aug 11, 2021

alonme commented Aug 11, 2021 • edited

graingert commented Aug 11, 2021

alonme commented Aug 11, 2021

graingert commented Aug 11, 2021

alonme commented Sep 22, 2021

brnosouza commented Sep 27, 2021

stephan-hesselmann-by commented Sep 27, 2021

Mause commented Sep 27, 2021

billcrook commented Sep 27, 2021

tiangolo commented Sep 27, 2021

adriangb commented Sep 27, 2021

v3ss0n commented Oct 2, 2021 • edited

brnosouza commented Oct 7, 2021

agronholm commented Oct 7, 2021

alonme commented Oct 7, 2021

alonme commented Oct 7, 2021

alonme commented Oct 7, 2021

codecov bot commented May 10, 2022 • edited

Codecov Report

github-actions bot commented May 10, 2022

tiangolo commented May 10, 2022

alonme commented Jul 23, 2021 •

edited by tiangolo

alonme commented Jul 23, 2021 •

edited

alonme commented Aug 11, 2021 •

edited

v3ss0n commented Oct 2, 2021 •

edited

codecov bot commented May 10, 2022 •

edited