Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Fix Korean translation for docs/ko/docs/index.md #3159

Merged
merged 3 commits into from May 4, 2021
Merged

馃寪 Fix Korean translation for docs/ko/docs/index.md #3159

merged 3 commits into from May 4, 2021

Conversation

SueNaEunYang
Copy link
Contributor

Hello, thank you all for your efforts.
While reading your translations, I found tiny things that I would recommend to change.

  • Complemented a few uncomfortable translations.
  • Changed the tones of some sentences to suit the standard translation guide.

Please see if you like those changes, and feel free to tell me if not :)

This PR complements docs/ko/docs/index.md (Korean translation of index.md)
related : #2017

- Complemented a few uncomfortable translations. 
- Changed the tones of some sentences to suit the standard translation guide.
Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize it at all, even though I wrote a #2017.
Thanks a lot!

@tiangolo tiangolo added lang-all Translations lang-ko Korean translations labels May 4, 2021
@tiangolo
Copy link
Owner

tiangolo commented May 4, 2021

Awesome, thank you @SueNaEunYang! 馃 馃攳

As @hard-coders already approved it and he's leading the Korean translations, I'll merge it right away, without waiting for more approvals. 馃殌

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #3159 (e78d8a6) into master (ce0ec06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2252837...e78d8a6. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

馃摑 Docs preview for commit e78d8a6 at: https://60910a2c702c4b00800f0963--fastapi.netlify.app

@tiangolo tiangolo merged commit 70746a7 into tiangolo:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants