Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add French translation for Tutorial - Background Tasks #3098

Merged

Conversation

Smlep
Copy link
Contributor

@Smlep Smlep commented Apr 18, 2021

Hey everyone!

Here is the PR to translate the Background Tasks section into french.
See the french translation tracking issue here.

Thanks for the reviews👌

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #3098 (c241e95) into master (70746a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3098   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a33b0...c241e95. Read the comment docs.

@Smlep Smlep mentioned this pull request Apr 18, 2021
@github-actions
Copy link
Contributor

📝 Docs preview for commit 0ff36ce at: https://607c41e93d1282b636f489ae--fastapi.netlify.app

@Smlep Smlep changed the title Add french translation for tutorial/background-tasks.md 🌐 Add french translation for tutorial/background-tasks.md Apr 18, 2021
Copy link
Contributor

@Jefidev Jefidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄 thanks for the work

@github-actions
Copy link
Contributor

📝 Docs preview for commit c678426 at: https://60808f28d86fce205343cf25--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add french translation for tutorial/background-tasks.md 🌐 Add French translation for Tutorial - Background Tasks May 4, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-fr French translations approved-2 and removed awaiting-review labels May 4, 2021
@tiangolo
Copy link
Owner

tiangolo commented May 4, 2021

Awesome, thank you @Smlep ! 🚀 🍰

And thanks for the reviews @NastasiaSaby, @Jefidev, @rjNemo! 🙇 ☕

@tiangolo tiangolo merged commit 05c859f into tiangolo:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-fr French translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants