New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for docs/ko/docs/tutorial/middleware.md
#2829
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2829 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13934 -35
=========================================
- Hits 13969 13934 -35 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 4c72d00 at: https://602df95ffc58236c636bbe5b--fastapi.netlify.app |
📝 Docs preview for commit a2ee84a at: https://602dfc29f05c9278bedee7d1--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome aboard 🎉 , and thanks for your works!
However, I hope you refer to other Korean translation PRs.
thanks for your review @hard-coders I learn a lot at this PR :) i will reflect all of your comment within 3days |
📝 Docs preview for commit b1d721f at: https://603dab8c9e0974360f0b7913--fastapi.netlify.app |
📝 Docs preview for commit 6bfb733 at: https://603dadb7792ea942f7dae553--fastapi.netlify.app |
📝 Docs preview for commit 0f2c891 at: https://603dc1ef73a63a63be3ec0a4--fastapi.netlify.app |
@hard-coders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for being late. Some feedback is here and you need to modify mkdocs.yml
file.
And... resolve outdated reviews, please.
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
i accepted your review :) thanks @hard-coders! i think, we uaually use "request", "response" in english at our daily work. |
@JeongHyeongKim |
accept hard-coders rules Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
thanks you for review this pr @hard-coders ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big appreciate of your works and great honor to check it 🚀
Can you update this file to latest?
Please feel free to check my reviews!
Thanks for your review. I will check your review and apply soon. |
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@0417taehyun |
📝 Docs preview for commit d8bd0ec at: https://632d13a9e36d8116f04e2148--fastapi.netlify.app |
📝 Docs preview for commit 2241794 at: https://639cccc5ed5882136dfea9e8--fastapi.netlify.app |
docs/ko/docs/tutorial/middleware.md
📝 Docs preview for commit 9e0718c at: https://649a1585acd72b10c561eaad--fastapi.netlify.app |
Nice, thanks for the help! @JeongHyeongKim 🤓🚀 And thanks for the reviews @hard-coders @0417taehyun 🎉 |
related issue -> #2017
I'm Happy to contribute to this repository by translate eng to ko.
if have any error or suggestion in my pr, please comment to in this pr :)
thanks for reviewer
This PR translates tutorial/middleware.md in Korean.
related: #2017 @