Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/tutorial/middleware.md #2829

Merged
merged 31 commits into from Jan 31, 2024

Conversation

JeongHyeongKim
Copy link
Contributor

related issue -> #2017
I'm Happy to contribute to this repository by translate eng to ko.
if have any error or suggestion in my pr, please comment to in this pr :)
thanks for reviewer

This PR translates tutorial/middleware.md in Korean.
related: #2017 @

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (d8bd0ec) 100.00%.
Report is 1238 commits behind head on master.

❗ Current head d8bd0ec differs from pull request most recent head 9e0718c. Consider uploading reports for the commit 9e0718c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13969     13934   -35     
=========================================
- Hits         13969     13934   -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4c72d00 at: https://602df95ffc58236c636bbe5b--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit a2ee84a at: https://602dfc29f05c9278bedee7d1--fastapi.netlify.app

Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard 🎉 , and thanks for your works!

However, I hope you refer to other Korean translation PRs.

docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
@JeongHyeongKim
Copy link
Contributor Author

JeongHyeongKim commented Feb 28, 2021

thanks for your review @hard-coders
There are many mistranslation in this PR. Because this pr is first pr in my carrer. :)

I learn a lot at this PR :)

i will reflect all of your comment within 3days

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

📝 Docs preview for commit b1d721f at: https://603dab8c9e0974360f0b7913--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

📝 Docs preview for commit 6bfb733 at: https://603dadb7792ea942f7dae553--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

📝 Docs preview for commit 0f2c891 at: https://603dc1ef73a63a63be3ec0a4--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Mar 27, 2021
@tiangolo tiangolo changed the title 🌐 Add Korean Translation for Tutorial - Middleware 🌐 Add Korean translation for Tutorial - Middleware Mar 27, 2021
@JeongHyeongKim
Copy link
Contributor Author

JeongHyeongKim commented May 11, 2021

@hard-coders
i accepted your reviews and modified this pr at 3/2
can i request re-review this pr?
thank you

Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for being late. Some feedback is here and you need to modify mkdocs.yml file.

And... resolve outdated reviews, please.

docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
@hard-coders hard-coders mentioned this pull request May 11, 2021
JeongHyeongKim and others added 4 commits May 11, 2021 17:11
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
@JeongHyeongKim
Copy link
Contributor Author

i accepted your review :) thanks @hard-coders!
but i have some questionmark at above.

i think, we uaually use "request", "response" in english at our daily work.
so i suggest that the word "request", "response" use english in our translate contribution

@hard-coders
Copy link
Sponsor Contributor

@JeongHyeongKim
I sincerely understand what you mean, but I usually use "요청", "응답" in work. I'm not lying :)
By your logic, I also can claim we should use "요청". It's ambiguous. So we need a rule, official Python Korean docs.
In addition, backtick(`) is used to represent a code in markdown, however.

JeongHyeongKim and others added 2 commits May 11, 2021 18:12
accept hard-coders rules

Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
@JeongHyeongKim
Copy link
Contributor Author

thanks you for review this pr @hard-coders !
can i write a comment at #3167 about the rule that we talked today?
it can be a good reference to another contributer :)

Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big appreciate of your works and great honor to check it 🚀

Can you update this file to latest?

Please feel free to check my reviews!

docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/middleware.md Outdated Show resolved Hide resolved
@JeongHyeongKim
Copy link
Contributor Author

Thanks for your review. I will check your review and apply soon.
@0417taehyun

JeongHyeongKim and others added 10 commits December 9, 2021 11:36
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@JeongHyeongKim
Copy link
Contributor Author

@0417taehyun
your translation is better than my translation. i check your translation and accept your review :)
thank for your review

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@github-actions
Copy link
Contributor

📝 Docs preview for commit d8bd0ec at: https://632d13a9e36d8116f04e2148--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 2241794 at: https://639cccc5ed5882136dfea9e8--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Middleware 🌐 Add Korean translation for docs/ko/docs/tutorial/middleware.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 9e0718c at: https://649a1585acd72b10c561eaad--fastapi.netlify.app

@alejsdev alejsdev merged commit 7178eb4 into tiangolo:master Jan 31, 2024
32 checks passed
@alejsdev
Copy link
Collaborator

alejsdev commented Jan 31, 2024

Nice, thanks for the help! @JeongHyeongKim 🤓🚀

And thanks for the reviews @hard-coders @0417taehyun 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants