Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/advanced/conditional-openapi.md #2631

Merged

Conversation

sh0nk
Copy link
Contributor

@sh0nk sh0nk commented Jan 11, 2021

This PR translates advanced/conditional-openapi.md in Japanese.

This is my first PR to FastAPI docs by referring to https://fastapi.tiangolo.com/contributing/#existing-language . If I do any mistake, please let me know!

Also, I found this comment in an issue. Let me try to review the open PRs for Japanese translation since a lot of parts are already done but not reviewed in progress.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2631 (f30dbb9) into master (3279ef3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2631   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13629     13629           
=========================================
  Hits         13629     13629           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3279ef3...f30dbb9. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit d0161ad473c8d24f64398c86ae4dd3e81b7fcee8 at: https://5ffc84dd1e18095cdf40edaa--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for translation, great work!
I propose some improvements (and alternative).


必要であれば、設定と環境変数を利用して、OpenAPIを環境に応じて構成することが可能です。また、完全にOpenAPIを無効にすることもできます。

## セキュリティとAPI、ドキュメントについて
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## セキュリティとAPI、ドキュメントについて
## セキュリティとAPIとドキュメントについて

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changed to "## セキュリティとAPI、およびドキュメントについて" since I think "AとBとC" is a bit hard to read. Please let me know if it does not follow your suggestion.

docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
@sh0nk sh0nk force-pushed the translation/add-ja-conditional-openapi branch from d0161ad to 7711bf4 Compare January 16, 2021 06:18
@sh0nk
Copy link
Contributor Author

sh0nk commented Jan 16, 2021

@tokusumi Thank you for your quick review. Updated!

@github-actions
Copy link
Contributor

📝 Docs preview for commit 7711bf4 at: https://600285ce685d265c1fd72553--fastapi.netlify.app

@tokusumi
Copy link
Contributor

LGTM👍

Copy link
Contributor

@wakabame wakabame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!!

I propose that "conditional noun" would be translated as "条件付き noun". Since;

  • In mathematical term, "conditional probability" and "conditional expectation" are translated as "条件付き確率" and "条件付き期待値", respectively.
  • In azure doc (en, ja), "conditional access" is translated as "条件付きアクセス".

and I leave some improvements. Please take them if you feel they make this article better!

docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/conditional-openapi.md Outdated Show resolved Hide resolved
@sh0nk sh0nk force-pushed the translation/add-ja-conditional-openapi branch from be41bd7 to 66eb927 Compare April 5, 2022 03:12
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

📝 Docs preview for commit 66eb927 at: https://624bb44928025e2c48d0fea9--fastapi.netlify.app

@sh0nk
Copy link
Contributor Author

sh0nk commented Apr 5, 2022

@wakabame
Thanks for your suggestion. Yeah, thought that not all people are super familiar with "条件付き" representation initially, but the reference of Azure convinced me enough to follow.

All points makes sense enough and fixed all! could you check again?

Copy link
Contributor

@wakabame wakabame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sh0nk
LGTM!

Thank you for your quick action!!

@tiangolo tiangolo changed the title 🌐 Add Japanese translation for Advanced - Conditional OpenAPI 🌐 Add Japanese translation for docs/ja/docs/advanced/conditional-openapi.md May 9, 2022
@tiangolo
Copy link
Owner

tiangolo commented May 9, 2022

Great, thank you @sh0nk! 🍰

And thanks for the reviews @wakabame and @tokusumi ! 🍪

@tiangolo tiangolo enabled auto-merge (squash) May 9, 2022 18:29
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

📝 Docs preview for commit 32bed26 at: https://62795e20b66d6316da0263a8--fastapi.netlify.app

@tiangolo tiangolo merged commit 944f06a into tiangolo:master May 9, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
…napi.md` (tiangolo#2631)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants