New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md
#2415
🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md
#2415
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 540 532 -8
Lines 13969 13684 -285
==========================================
- Hits 13969 13684 -285 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 37c5cbf at: https://5fbe363d5ff4c348af8cbdd9--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big appreciate of you works and great honor to check it.
Feel free to check my reviews 🚀
Also, please update (fetch) your files to latest version to solve the conflicts
|
||
이제는 더이상 이 매개변수를 마음에 들어하지 않는다고 가정해 봅시다. | ||
|
||
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다. | |
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다</abbr>고 확실하게 문서에서 보여주고 싶습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated means "it will be not used in near future". So I left the original word, deprecated
.
How about
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다. | |
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않을 예정이다</abbr>라고 확실하게 문서에서 보여주고 싶습니다. |
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
📝 Docs preview for commit 5c04347 at: https://6199f903392a06d7423cfed1--fastapi.netlify.app |
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
📝 Docs preview for commit 1792199 at: https://6199fa7b281d3ad7cc51e2f5--fastapi.netlify.app |
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Thanks to @kty4119 and especially @0417taehyun :D |
📝 Docs preview for commit 0ad4e27 at: https://6199fbfec6e9b4d4d5bbd426--fastapi.netlify.app |
📝 Docs preview for commit 3628921 at: https://62e89b7f7b0c347077f39a3e--fastapi.netlify.app |
docs/ko/docs/tutorial/query-params-str-validations.md
📝 Docs preview for commit 238ab81 at: https://649a12bf7ce5230f7850e2a4--fastapi.netlify.app |
Thanks for your work @hard-coders 🪄 And thanks for the reviews @kty4119 and @0417taehyun 🤓✌️ |
This PR translates
tutorial/query-params-str-validations.md
in Korean.related: #2017