🌐 Add Korean translation for `docs/ko/docs/python-types.md` #2267

jrim · 2020-10-30T08:44:59Z

Korean translated 'python-types.md' #2017

codecov · 2020-10-30T08:46:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (d2a0e65) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head d2a0e65 differs from pull request most recent head 655e68d. Consider uploading reports for the commit 655e68d to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##            master     #2267     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       240    -300     
  Lines        13969      7101   -6868     
===========================================
- Hits         13969      7101   -6868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2020-10-30T08:48:43Z

📝 Docs preview for commit eb3ac10 at: https://5f9bd3234b8985d7301987f1--fastapi.netlify.app

hard-coders

I updated #2017 a few days ago. I want you to follow it.
Sorry for the late update.😭

docs/ko/docs/python-types.md

Co-authored-by: hard_coder <rurouni24@gmail.com>

github-actions · 2020-11-06T12:13:14Z

📝 Docs preview for commit d2a0e65 at: https://5fa53daa31aca1ff592e3b27--fastapi.netlify.app

hard-coders

We are almost there!😎

But there's one more thing... to do. Please replace "에디터" with "편집기". It is also to follow python's official Korean docs.

docs/ko/docs/python-types.md

SueNaEunYang

Hello, thank you for your efforts.
I added some comments here.
I hope they can be of any help for you :)

docs/ko/docs/python-types.md

SueNaEunYang · 2021-05-04T09:58:45Z

docs/ko/docs/python-types.md

+```
+
+!!! info
+    Pydantic<에 대해 더 배우고 싶다면 <a href="https://pydantic-docs.helpmanual.io/" class="external-link" target="_blank">공식 문서</a>를 참고하세요.</a>


How about "참고하십시오/확인해보십시오." rather than "참고하세요." ?

docs/ko/docs/python-types.md

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Co-authored-by: Spike <rurouni24@gmail.com>

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Co-authored-by: Spike <rurouni24@gmail.com>

jrim · 2021-05-04T12:08:17Z

Thanks for reviewing y'all

hard-coders

I reviewed some lines more, like

!!! tip

to

!!! tip "팁"

Please see reviews and modify what you can accept.
I hope this PR merged soon:D

docs/ko/docs/python-types.md

Co-authored-by: Spike <rurouni24@gmail.com>

tiangolo · 2023-06-26T17:40:34Z

📝 Docs preview for commit 655e68d at: https://6499cd5a4a964606cbd74e3b--fastapi.netlify.app

hard-coders

It has been forgotten for a long time, so the Type Hints with Metadata Annotations section isn't reflected in this PR. Despite the problem, because it is well-translated, I approve it and will create a new pull request to add the section.

I'm sorry for not getting back to it sooner. 🙇🏻

alejsdev · 2024-01-22T19:34:50Z

Thank you! @jrim 🐱

And thanks for the reviews @hard-coders and @SueNaEunYang 🎉

Add Korean Translation for Python-types tiangolo#2017

eb3ac10

jrim changed the title ~~Add Korean Translation for Python-types #2017~~ Add Korean Translation for Python-types Oct 30, 2020

jrim changed the title ~~Add Korean Translation for Python-types~~ Add Korean Translation for python-types.md Oct 30, 2020

tiangolo added awaiting-review hacktoberfest-accepted lang-all Translations lang-ko Korean translations labels Nov 1, 2020

hard-coders reviewed Nov 6, 2020

View reviewed changes

jrim and others added 4 commits November 6, 2020 21:08

Update docs/ko/docs/python-types.md

a7a828c

Co-authored-by: hard_coder <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

c60088b

Co-authored-by: hard_coder <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

6c28c04

Co-authored-by: hard_coder <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

d2a0e65

Co-authored-by: hard_coder <rurouni24@gmail.com>

hard-coders reviewed Nov 7, 2020

View reviewed changes

docs/ko/docs/python-types.md Outdated Show resolved Hide resolved

hard-coders reviewed Nov 7, 2020

View reviewed changes

docs/ko/docs/python-types.md Outdated Show resolved Hide resolved

SueNaEunYang reviewed May 4, 2021

View reviewed changes

jrim and others added 11 commits May 4, 2021 21:04

Update docs/ko/docs/python-types.md

d4bdc81

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Update docs/ko/docs/python-types.md

efe4f2c

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

79adb0e

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

698665e

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

e646215

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

e596484

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

2e4f16d

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

c3df2b7

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

d5f04dc

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

f8f5c46

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

a214848

Co-authored-by: Spike <rurouni24@gmail.com>

jrim and others added 8 commits May 4, 2021 21:06

Update docs/ko/docs/python-types.md

8947f18

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

a1bf22c

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Update docs/ko/docs/python-types.md

4b3c49f

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Update docs/ko/docs/python-types.md

a489d17

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Update docs/ko/docs/python-types.md

b105db1

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Update docs/ko/docs/python-types.md

0ae56a2

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Update docs/ko/docs/python-types.md

a3bcf88

Co-authored-by: SueNaeunYang <artisticsue@naver.com>

Update docs/ko/docs/python-types.md

f68664b

Co-authored-by: Spike <rurouni24@gmail.com>

hard-coders reviewed May 11, 2021

View reviewed changes

docs/ko/docs/python-types.md Outdated Show resolved Hide resolved

docs/ko/docs/python-types.md Outdated Show resolved Hide resolved

docs/ko/docs/python-types.md Outdated Show resolved Hide resolved

docs/ko/docs/python-types.md Outdated Show resolved Hide resolved

jrim and others added 4 commits May 11, 2021 14:07

Update docs/ko/docs/python-types.md

5364b82

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

cd37ecc

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

fc793b9

Co-authored-by: Spike <rurouni24@gmail.com>

Update docs/ko/docs/python-types.md

cb4b30b

Co-authored-by: Spike <rurouni24@gmail.com>

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022

translated by tiangolo#2267

30c253a

Merge branch 'master' into translation/ko

6cf7cda

tiangolo changed the title ~~Add Korean Translation for python-types.md~~ 🌐 Add Korean Translation for docs/ko/docs/python-types.md Jun 26, 2023

tiangolo changed the title ~~🌐 Add Korean Translation for docs/ko/docs/python-types.md~~ 🌐 Add Korean translation for docs/ko/docs/python-types.md Jun 26, 2023

tiangolo added awaiting-review and removed awaiting-review labels Jun 26, 2023

🎨 [pre-commit.ci] Auto format from pre-commit.com hooks

655e68d

tiangolo requested review from hard-coders and SueNaEunYang January 15, 2024 15:42

hard-coders approved these changes Jan 16, 2024

View reviewed changes

tiangolo added approved-1 and removed awaiting-review labels Jan 22, 2024

alejsdev merged commit 2a8f8d1 into tiangolo:master Jan 22, 2024
30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌐 Add Korean translation for `docs/ko/docs/python-types.md` #2267

🌐 Add Korean translation for `docs/ko/docs/python-types.md` #2267

jrim commented Oct 30, 2020 •

edited

codecov bot commented Oct 30, 2020 •

edited

github-actions bot commented Oct 30, 2020

hard-coders left a comment

github-actions bot commented Nov 6, 2020

hard-coders left a comment •

edited

SueNaEunYang left a comment

SueNaEunYang May 4, 2021

jrim commented May 4, 2021 •

edited

hard-coders left a comment

tiangolo commented Jun 26, 2023

hard-coders left a comment

alejsdev commented Jan 22, 2024

🌐 Add Korean translation for docs/ko/docs/python-types.md #2267

🌐 Add Korean translation for docs/ko/docs/python-types.md #2267

Conversation

jrim commented Oct 30, 2020 • edited

codecov bot commented Oct 30, 2020 • edited

Codecov Report

github-actions bot commented Oct 30, 2020

hard-coders left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 6, 2020

hard-coders left a comment • edited

Choose a reason for hiding this comment

SueNaEunYang left a comment

Choose a reason for hiding this comment

SueNaEunYang May 4, 2021

Choose a reason for hiding this comment

jrim commented May 4, 2021 • edited

hard-coders left a comment

Choose a reason for hiding this comment

tiangolo commented Jun 26, 2023

hard-coders left a comment

Choose a reason for hiding this comment

alejsdev commented Jan 22, 2024

🌐 Add Korean translation for `docs/ko/docs/python-types.md` #2267

🌐 Add Korean translation for `docs/ko/docs/python-types.md` #2267

jrim commented Oct 30, 2020 •

edited

codecov bot commented Oct 30, 2020 •

edited

hard-coders left a comment •

edited

jrim commented May 4, 2021 •

edited