Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/tutorial/security/index.md #1962

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 23, 2020

This PR translates the tutorial/security/index.md to Japanese.
Please review tutorial/security/index.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 and #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (84efdbd) 100.00%.

❗ Current head 84efdbd differs from pull request most recent head 6a4ee13. Consider uploading reports for the commit 6a4ee13 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1962     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890     

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1b290cb at: https://5f42a40d4c0993438224fa21--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
docs/ja/docs/tutorial/security/index.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/index.md Outdated Show resolved Hide resolved
SwftAlpc and others added 3 commits October 30, 2020 01:11
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for your suggetion!
I adopt it.
May I ask for confirmation?

@github-actions
Copy link
Contributor

📝 Docs preview for commit 84efdbd at: https://5f9aea86363b7519e0da33ed--fastapi.netlify.app

@tokusumi
Copy link
Contributor

Thank you for your help!
However, check docs/ja/docs/index.md. It contains conflict messages.

@tiangolo tiangolo changed the title Add tutorial/security/index.md Japanese ver 🌐 Add Japanese translation for docs/ja/docs/tutorial/security/index.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Owner

Thank you @SwftAlpc ! 🤓

This was covered by #5798, so I'll now close this one, but thanks for your work! 🚀

@tiangolo tiangolo closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants