Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Portuguese translation of docs/async.md #1330

Merged
merged 2 commits into from Aug 18, 2021

Conversation

Serrones
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1330 (8a10d0c) into master (4e77737) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #1330     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          226       409    +183     
  Lines         6785     10244   +3459     
===========================================
+ Hits          6785     10244   +3459     
Impacted Files Coverage Δ
tests/main.py 100.00% <0.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/requests.py 100.00% <0.00%> (ø)
fastapi/responses.py 100.00% <0.00%> (ø)
fastapi/exceptions.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e77737...8a10d0c. Read the comment docs.

@Serrones Serrones force-pushed the async-portuguese-translation branch 2 times, most recently from a35cf84 to 6c554c4 Compare April 27, 2020 22:51
Copy link
Contributor

@cassiobotaro cassiobotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit: Crush is an English word, I think it should be italic.

@Serrones Serrones force-pushed the async-portuguese-translation branch from 6c554c4 to 96a2289 Compare May 2, 2020 13:20
@tiangolo
Copy link
Owner

Thanks! 🚀

Do you guys think "crush" is understandable? I just updated the Spanish version to use "la persona que te gusta", which is kinda long 😞 but there's no better alternative.

I don't know if in Portuguese there's a better word for that, would people normally say "crush"? Or would it be better to make it something like "a pessoa da que você gosta" or similar?

I also added a lot of emojis of 😍 to later refer to that person as "esa persona 😍 " instead of writing the whole thing again.

Maybe we could do the same for the Portuguese version?

Here's the new Spanish version: https://github.com/tiangolo/fastapi/blob/master/docs/es/docs/async.md

@Serrones
Copy link
Contributor Author

Serrones commented May 17, 2020

Thanks!

Do you guys think "crush" is understandable? I just updated the Spanish version to use "la persona que te gusta", which is kinda long but there's no better alternative.

I don't know if in Portuguese there's a better word for that, would people normally say "crush"? Or would it be better to make it something like "a pessoa da que você gosta" or similar?

I also added a lot of emojis of to later refer to that person as "esa persona " instead of writing the whole thing again.

Maybe we could do the same for the Portuguese version?

Here's the new Spanish version: https://github.com/tiangolo/fastapi/blob/master/docs/es/docs/async.md

Hey @tiangolo , here in Brazil it's common use some words in english mixing with portuguese sentences and expressions. Crush is a word that is cool and natural nowadays. We have a word in portuguese that translates perfectly crush, paquera. But it is so old, kkkkk. I wil talk with @cassiobotaro and @marcosmmb to see if we keep crush or replace with a portuguese word that reflects the exact meaning. And about the emoji 😍 is amazing.
Thanks for the notes.
Cheers

@cassiobotaro
Copy link
Contributor

I think we should keep crush in italic. As you said, "is a word that is cool and natural nowadays".

@Serrones Serrones force-pushed the async-portuguese-translation branch from 96a2289 to 6bffc3d Compare May 17, 2020 21:05
@tiangolo
Copy link
Owner

Awesome, sounds great with crush then. 🚀

@tiangolo tiangolo added lang-all Translations lang-pt Portuguese translations labels Jun 7, 2020
Copy link
Contributor

@lsglucas lsglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo and correct me if I am wrong but I believe that this page isn't in mkdocs.yml yet

docs/pt/docs/async.md Outdated Show resolved Hide resolved
@tiangolo tiangolo changed the title Portuguese translation of async.md 🌐 Portuguese translation of docs/async.md Aug 18, 2021
Co-authored-by: Lucas <61513630+lsglucas@users.noreply.github.com>
@tiangolo
Copy link
Owner

Thanks @Serrones for your contribution! 🚀

And thanks @cassiobotaro and @lsglucas for the reviews! 🍰

@tiangolo tiangolo enabled auto-merge (squash) August 18, 2021 13:24
@tiangolo tiangolo merged commit dda105c into tiangolo:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-pt Portuguese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants