New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Portuguese translation of docs/async.md
#1330
🌐 Portuguese translation of docs/async.md
#1330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1330 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 226 409 +183
Lines 6785 10244 +3459
===========================================
+ Hits 6785 10244 +3459
Continue to review full report at Codecov.
|
a35cf84
to
6c554c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit: Crush is an English word, I think it should be italic.
6c554c4
to
96a2289
Compare
Thanks! 🚀 Do you guys think "crush" is understandable? I just updated the Spanish version to use "la persona que te gusta", which is kinda long 😞 but there's no better alternative. I don't know if in Portuguese there's a better word for that, would people normally say "crush"? Or would it be better to make it something like "a pessoa da que você gosta" or similar? I also added a lot of emojis of 😍 to later refer to that person as "esa persona 😍 " instead of writing the whole thing again. Maybe we could do the same for the Portuguese version? Here's the new Spanish version: https://github.com/tiangolo/fastapi/blob/master/docs/es/docs/async.md |
Hey @tiangolo , here in Brazil it's common use some words in english mixing with portuguese sentences and expressions. |
I think we should keep crush in italic. As you said, "is a word that is cool and natural nowadays". |
96a2289
to
6bffc3d
Compare
Awesome, sounds great with crush then. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small typo and correct me if I am wrong but I believe that this page isn't in mkdocs.yml yet
docs/async.md
Co-authored-by: Lucas <61513630+lsglucas@users.noreply.github.com>
Thanks @Serrones for your contribution! 🚀 And thanks @cassiobotaro and @lsglucas for the reviews! 🍰 |
No description provided.