Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial CRA setup #1

Merged
merged 14 commits into from Sep 22, 2021
Merged

initial CRA setup #1

merged 14 commits into from Sep 22, 2021

Conversation

georgeweiler
Copy link
Contributor

major libraries installed with this PR:

  • create-react-app
  • eslint / prettier
  • husky / lint-staged
  • storybook
  • chakra-ui

michalsmiarowski
michalsmiarowski requested changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍 Left some comments to look at before the merge

package.json Outdated Show resolved Hide resolved
src/stories/Button.stories.tsx Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
r-czajkowski
r-czajkowski requested changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@r-czajkowski r-czajkowski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍. Left few comments to look at before merge.

.eslintignore Outdated Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.prettierrc.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@georgeweiler
chore: Remove storybook boilerplate
4a28c97
@georgeweiler
chore: Update several repo configuration settings
1ddb707 
- Fine-tunes the linting config
- Adds pre-commit config
- Fixes storybook dependency issue by using resolutions instead of skipping
the preflight check
@georgeweiler
chore: Update eslint and prettier configs to use keep plugins
ea6026b
r-czajkowski
r-czajkowski requested changes Sep 16, 2021
View reviewed changes
.husky/commit-msg Outdated Show resolved Hide resolved
r-czajkowski
r-czajkowski requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@r-czajkowski r-czajkowski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooks work like a charm! 🚀

I've run yarn format:fix on my local machine and seems like some files need to be formatted. Once we commit auto-formatted changes, remember about adding this commit hash to the .git-blame-ignore-revs file.

.lintstagedrc Outdated Show resolved Hide resolved
.lintstagedrc Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
@nkuba nkuba mentioned this pull request Sep 21, 2021
Merged
r-czajkowski
r-czajkowski approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@r-czajkowski r-czajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. We can discuss the commit rules later and address it in a follow-up PR. Leaving final approval to @michalsmiarowski.

nkuba
nkuba reviewed Sep 21, 2021
View reviewed changes
.eslintrc.js Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
r-czajkowski
r-czajkowski reviewed Sep 22, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@georgeweiler georgeweiler mentioned this pull request Sep 22, 2021
Merged
pdyraga
pdyraga approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@pdyraga pdyraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick pass, looks good to me, and I see all commits from other reviewers were addressed just like they requested. Let's 🚢

package.json
@@ -0,0 +1,72 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a license and I think it should be GPLv3.

@pdyraga pdyraga merged commit 2477bb3 into main Sep 22, 2021
@pdyraga pdyraga deleted the cra-setup branch September 22, 2021 16:43
@georgeweiler georgeweiler mentioned this pull request Jan 27, 2022
Closed
georgeweiler pushed a commit that referenced this pull request Sep 8, 2022
@pdyraga
Merge pull request #1 from threshold-network/cra-setup
3fabb80 
Initial CRA setup

major libraries installed:
    create-react-app
    eslint / prettier
    husky / lint-staged
    storybook
    chakra-ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhluongo mhluongo mhluongo left review comments

@pdyraga pdyraga pdyraga approved these changes

@nkuba nkuba nkuba left review comments

@michalsmiarowski michalsmiarowski michalsmiarowski requested changes

@r-czajkowski r-czajkowski r-czajkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@georgeweiler @mhluongo @pdyraga @nkuba @michalsmiarowski @r-czajkowski