CI workflows configuration #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkuba
commented
Sep 21, 2021
.github/workflows/format.yaml
Outdated
|
|
||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: "16" |
There was a problem hiding this comment.
Are there any expectations regarding the node version the dashboard should be built with?
This comment has been minimized.
This comment has been minimized.
.github/workflows/dashboard.yaml
Outdated
| @@ -0,0 +1,107 @@ | |||
| name: Dashboard | |||
There was a problem hiding this comment.
Can we align workflows and files naming to what we have in other repos (e.g. keep-core). We could name this file as dashboard-testnet.yml and the workflow as Token Dashboard / Testnet. WDYT?
There was a problem hiding this comment.
I'm cool with these changes & the related change requests so we're keeping things consistent with Keep.
| @@ -0,0 +1,95 @@ | |||
| name: Dashboard Build and Deploy for Mainnet | |||
There was a problem hiding this comment.
And same here regarding naming. What do you think about naming the file dashboard-mainnet.yml and the workflow as Token Dashboard / Mainnet?
The workflow will run on each push to main branch or a pull request to execute a yarn script that checks code formatting.
The dashboard will be built on each pull request and main branch merge. Dashboard will be build with the latest ropsten contracts for pull requests and published to a preview bucket. Once a PR is merged to main the version of dashboard will be built for ropsten and deployed to testnet bucket.
It is expected that mainnet dashboard releases are created on `releases/mainnet/*` branches. The code pushed to the branch should have dependencies updated to the versions of contracts that we want to use for mainnet. (this could be changed later to pull the latest npm packages tagged with `mainnet`). Once a PR is created a dashboard preview will be published and comment added to the PR. When the dashboard is ready to publish the deployer should manually approve the deployment.
The contracts are not yet published to NPM, nor required by the dashboard. We're leaving it as a placeholder.
We want to publish a preview of mainnet dashboard also when a push to main happens. We will build the dashboard with the latest mainnet contract dependencies.
When a new release is published we will deploy the dashboard build with the latest mainnet contracts. We also give possibility to manually invoke the workflow with workflow_dispatch.
We want to resolve the latest version of a dependency package that is a tag, so we switched to upgrade command.
Renemed the files and jobs for consistency.
The API has changed, hence we need to align with the latest changes. See more: https://github.com/actions/github-script#breaking-changes-in-v5
georgeweiler
previously approved these changes
Sep 28, 2021
michalinacienciala
requested changes
Sep 29, 2021
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-setup/. |
Point to index.html for smooth reference to the website.
We do similiar for ropsten one, we need to specifiy those paramters so the bucket correctly reference the website.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-setup/index.html. |
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-setup/index.html. |
georgeweiler
approved these changes
Oct 6, 2021
michalinacienciala
approved these changes
Oct 7, 2021
georgeweiler
pushed a commit
that referenced
this pull request
Sep 8, 2022
CI workflows configuration Workflow: dashboard.yaml - builds, tests, and deploys for testnet (ropsten) Invoked on: * main merge (push with branches: main), * Pull Request commits (pull_request), * manually with (workflow_dispatch). Jobs: * format - runs linting and prettier code formatting checks * build-and-test - runs build; tests are not yet available in the repository * build-and-deploy-testnet - resolves latest dependencies for ropsten, then: for PR commits: builds and deploys a preview to preview.dashboard.test.threshold.network/<REF> for main merge: builds and deploys dashboard.test.threshold.network Workflow: release-mainnet.yml - builds, tests, and deploys for mainnet Invoked on: * main merge (push with branches: main), * Pull Requests on releases/mainnet/** branches, * published releases (release with types: published), * manually with (workflow_dispatch). It will pull the latest contracts dependencies pushed to npm registry and tagged with mainnet. For PR made on releases/mainnet/** branch it won't resolve the latest mainnet dependencies, but use the ones already configured in package.json. Jobs: * build-mainnet - builds dashboard and stores the artifacts for following jobs * deploy-preview-mainnet - deploys dashboard automatically to preview.dashboard.threshold.network/<REF> * deploy-mainnet - runs for published release or workflow dispatch; requires manual approval to deploy dashboard to dashboard.threshold.network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow:
dashboard.yaml- builds, tests, and deploys for testnet (ropsten)Invoked on:
pushwithbranches: main),pull_request),workflow_dispatch).Jobs:
format- runs linting and prettier code formatting checksbuild-and-test- runs build; tests are not yet available in the repositorybuild-and-deploy-testnet- resolves latest dependencies for ropsten, then:preview.dashboard.test.threshold.network/<REF>dashboard.test.threshold.networkWorkflow:
release-mainnet.yml- builds, tests, and deploys for mainnetInvoked on:
pushwithbranches: main),releases/mainnet/**branches,releasewithtypes: published),workflow_dispatch).It will pull the latest contracts dependencies pushed to npm registry and tagged with
mainnet.For PR made on
releases/mainnet/**branch it won't resolve the latest mainnet dependencies, but use the ones already configured inpackage.json.Jobs:
build-mainnet- builds dashboard and stores the artifacts for following jobsdeploy-preview-mainnet- deploys dashboard automatically topreview.dashboard.threshold.network/<REF>deploy-mainnet- runs for published release or workflow dispatch; requires manual approval to deploy dashboard todashboard.threshold.networkThis PR depends on #1