Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump omniauth-github and omniauth #2473

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024

Bumps omniauth-github and omniauth. These dependencies needed to be updated together.
Updates omniauth-github from 1.4.0 to 2.0.1

Release notes

Sourced from omniauth-github's releases.

Require OmniAuth 2.0.0

As of v2.0.0 of this gem, it will require OmniAuth 2.0.0. This is due to changes that came with OmniAuth that required a breaking change in this gem. Because we changed the strategy's code, you should not need to change any omniauth-github specific code.

You should refer to OmniAuth's v2.0.0 release and/or the v2.0 upgrade guide when upgrading OmniAuth to v2.0.

Commits
  • 0ac46b5 Release 2.0.1
  • fa3e9cf Merge pull request #102 from jessieay/master
  • 684a74a Upgrade omniauth-oauth2 dependency
  • 1633cbb Merge pull request #100 from petergoldstein/feature/add_modern_rubies
  • 23cfa75 Add Ruby 2.7, 3.0, and 3.1 to the CI matrix
  • d2d9e01 Merge pull request #96 from gogainda/patch-1
  • 4ac10c7 Update ruby.yml
  • f4e28d9 Update ruby.yml
  • 027b861 Update ruby.yml
  • 1f77226 Merge pull request #95 from BobbyMcWho/chores-2020-01-12
  • Additional commits viewable in compare view

Updates omniauth from 1.9.2 to 2.1.2

Release notes

Sourced from omniauth's releases.

v2.1.0

This release adds Ruby 3.0+ support.

Due to kwarg changes in ruby 3, we have bumped the minimum required version of Rack to 2.2.3, which is where ruby3 support was added.

Releasing as a minor as dependency resolution should fail at install if an application is locked to a rack below new minimum.

Full Changelog: omniauth/omniauth@v2.0.4...v2.1.0

v2.0.4

This release removes unnecessary warning logging when accessing GET routes that are not related to the OmniAuth request path.

Thanks to @​charlie-wasp and @​sponomarev at Evil Martians for the bug find and subsequent PR.

Fix rescuing of application errors when call_app! is used.

As a consequence of the changes that were merged in #689, errors thrown by strategies that utilize other_phase (or more specifically call_app!), would be caught by omniauth, causing headaches for folks looking to have those errors handled by their application. This should allow for errors that come from the app to pass through, while passing errors that come from the authentication phases to the fail! handler.

Resolves #1030

Fix for incorrect order of request_validation_phase in test_mode.

@​jsdalton gave an awesome report of the issue present in test_mode in #1033

The current implementation of mock_call was verifying the token for all requests, regardless of whether the current path is on the omniauth request path. The change was introduced recently in 1b784ff. See #1032 for details.

This creates two problems:

  1. When test mode is on, the authenticity verification logic is run inappropriately against requests where this may not even be wanted.
  2. The behavior varies from actual production behavior, potentially allowing bugs to be introduced by unwary developers.

Note that this bug was only present when OmniAuth was configured for test_mode and using the mock_call phases.

Allow passing rack-protection configuration to default request_validation_phase

This release now properly allows an instance of OmniAuth::AuthenticityTokenProtection (with passed in rack-protection configuration) to be used as the request_validation_phase.

Thanks @​jkowens #1027

If you haven't already read the release notes for v2.0.0, you should do so.

v2.0.0

Version 2.0 of OmniAuth includes some changes that may be breaking depending on how you use OmniAuth in your app.

Many thanks to the folks who contributed in code and discussion for these changes.

OmniAuth now defaults to only POST as the allowed request_phase method.

Hopefully, you were already doing this as a result of the warnings due to CVE-2015-9284.

... (truncated)

Commits
  • 36f46c4 Prep for next release
  • a13cd11 Merge pull request #1122 from nschonni/jruby-hack
  • a0b31ec fix: conditional delegate require Rack/JRuby
  • 79d0c9a Merge pull request #1118 from nschonni/remove-old-conditions
  • c160e48 Merge pull request #1102 from madogiwa0124/update-tesed-ruby-versions
  • b6cc0cc chore: Remove conditions for old (J)Ruby
  • c6e01a6 Merge pull request #1110 from nschonni/dependabot-setup
  • 4e9563f ci: update coverals to v2
  • fa2674c ci: update actions/checkout to v3
  • d050031 chore: add Dependabot for version updates
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Apr 29, 2024
@smaboshe
Copy link
Contributor

smaboshe commented May 3, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/multi-4b04f7456c branch from 25622e6 to 18e9bd6 Compare May 3, 2024 08:50
@smaboshe
Copy link
Contributor

smaboshe commented May 3, 2024

Our tests are currently failing because of the change from 1.x to 2.x. For 2.x, "OmniAuth now defaults to only POST as the allowed request_phase method"

Ref:

smaboshe added a commit that referenced this pull request May 3, 2024
We are currently using OmniAuth version 1.x. Version 2.x is now
available. In the version 2.x announcement, OmniAuth announced that
"OmniAuth now defaults to only POST as the allowed request_phase
method."

This commit changes offending GET requests to POST and adds the
`omniauth-rails_csrf_protection` gem.

Ref:
- #2473 (comment)
- https://www.mintbit.com/blog/updating-omniauth-from-version-1-to-2
- https://github.com/omniauth/omniauth/releases/tag/v2.0.0
- #2452
smaboshe added a commit that referenced this pull request May 3, 2024
We are currently using OmniAuth version 1.x. Version 2.x is now
available. In the version 2.x announcement, OmniAuth announced that
"OmniAuth now defaults to only POST as the allowed request_phase
method."

This commit changes offending GET requests to POST and adds the
`omniauth-rails_csrf_protection` gem.

Ref:
- #2473 (comment)
- #2469
- https://www.mintbit.com/blog/updating-omniauth-from-version-1-to-2
- https://github.com/omniauth/omniauth/releases/tag/v2.0.0
- #2452
smaboshe added a commit that referenced this pull request May 6, 2024
We are currently using OmniAuth version 1.x. Version 2.x is now
available. In the version 2.x announcement, OmniAuth announced that
"OmniAuth now defaults to only POST as the allowed request_phase
method."

This commit changes offending GET requests to POST and adds the
`omniauth-rails_csrf_protection` gem.

Ref:
- #2473 (comment)
- #2469
- https://www.mintbit.com/blog/updating-omniauth-from-version-1-to-2
- https://github.com/omniauth/omniauth/releases/tag/v2.0.0
- #2452
smaboshe added a commit that referenced this pull request May 6, 2024
We are currently using OmniAuth version 1.x. Version 2.x is now
available. In the version 2.x announcement, OmniAuth announced that
"OmniAuth now defaults to only POST as the allowed request_phase
method."

This commit changes offending GET requests to POST and adds the
`omniauth-rails_csrf_protection` gem.

Ref:
- #2473 (comment)
- #2469
- https://www.mintbit.com/blog/updating-omniauth-from-version-1-to-2
- https://github.com/omniauth/omniauth/releases/tag/v2.0.0
- #2452
@smaboshe
Copy link
Contributor

smaboshe commented May 6, 2024

@dependabot rebase

Bumps [omniauth-github](https://github.com/intridea/omniauth-github) and [omniauth](https://github.com/omniauth/omniauth). These dependencies needed to be updated together.

Updates `omniauth-github` from 1.4.0 to 2.0.1
- [Release notes](https://github.com/intridea/omniauth-github/releases)
- [Commits](omniauth/omniauth-github@v1.4.0...v2.0.1)

Updates `omniauth` from 1.9.2 to 2.1.2
- [Release notes](https://github.com/omniauth/omniauth/releases)
- [Commits](omniauth/omniauth@v1.9.2...v2.1.2)

---
updated-dependencies:
- dependency-name: omniauth-github
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: omniauth
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/multi-4b04f7456c branch from 18e9bd6 to a4f0b83 Compare May 6, 2024 11:17
Copy link
Contributor Author

dependabot bot commented on behalf of github May 13, 2024

Superseded by #2479.

@dependabot dependabot bot closed this May 13, 2024
@dependabot dependabot bot deleted the dependabot/bundler/multi-4b04f7456c branch May 13, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant