Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for OmniAuth version 2.x #2474

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

smaboshe
Copy link
Contributor

@smaboshe smaboshe commented May 3, 2024

We are currently using OmniAuth version 1.x. Version 2.x is now available. In the version 2.x announcement, OmniAuth announced that "OmniAuth now defaults to only POST as the allowed request_phase method."

This commit changes offending GET requests to POST and adds the omniauth-rails_csrf_protection gem.

Ref:

@smaboshe smaboshe self-assigned this May 3, 2024
We are currently using OmniAuth version 1.x. Version 2.x is now
available. In the version 2.x announcement, OmniAuth announced that
"OmniAuth now defaults to only POST as the allowed request_phase
method."

This commit changes offending GET requests to POST and adds the
`omniauth-rails_csrf_protection` gem.

Ref:
- #2473 (comment)
- #2469
- https://www.mintbit.com/blog/updating-omniauth-from-version-1-to-2
- https://github.com/omniauth/omniauth/releases/tag/v2.0.0
- #2452
@smaboshe smaboshe force-pushed the smaboshe-prepare-for-omniauth-2 branch from 62ea222 to c89c676 Compare May 6, 2024 11:06
@smaboshe smaboshe merged commit 54a0b76 into main May 6, 2024
1 check passed
@smaboshe smaboshe deleted the smaboshe-prepare-for-omniauth-2 branch May 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant