Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ruby 2.6 support #1521

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

dougmrqs
Copy link
Contributor

@dougmrqs dougmrqs commented Nov 18, 2022

Removes support for Ruby 2.6 due to EOL.

Referent to #1511

@dougmrqs dougmrqs force-pushed the drop-support-ruby-2.6 branch 2 times, most recently from f4fb1ff to 76a0a83 Compare November 21, 2022 12:56
@dougmrqs
Copy link
Contributor Author

@vsppedro can you please run the pipeline again? The failing test does not seem to be related to the removed version.

@vsppedro
Copy link
Collaborator

Hi @dougmrqs, you're right. It's not about this PR. It's an intermittent test. I intend to take a closer look as soon as I have some time.

Thank you for your contribution. I'll merge this once we start discussing creating the next major release. We currently have another version in progress.

@vsppedro vsppedro added this to the 6.0.0 milestone Nov 21, 2022
@vsppedro
Copy link
Collaborator

vsppedro commented Mar 21, 2023

Hi, @dougmrqs, would be possible to fix the conflict in this PR? If you don't have the time please let me know. Thank you again for working on this.

@dougmrqs
Copy link
Contributor Author

@vsppedro done! LMK if anything else comes up.

@vsppedro vsppedro merged commit c87b957 into thoughtbot:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants