Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ruby 2.7 support #1547

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

HeitorMC
Copy link
Contributor

Removes support for Ruby 2.6 due to EOL.

I also checked that Rails 6.0.x will hit EOL on June 1st, 2023. If you guys want to, I can remove it in this PR, or create a new one :)

@vsppedro vsppedro added this to the 6.0.0 milestone Mar 21, 2023
@vsppedro
Copy link
Collaborator

Thanks for working on this. I think is better to create another PR to remove Rails 6.

@HeitorMC
Copy link
Contributor Author

Hmmm, the rubocop is failing and I didn't change the file that it's breaking 🤔

Also, that line it's present on the main branch

LIST_ITEM_REGEXP = /\A((?:[a-z0-9]+(?:\)|\.)|\*) )/.freeze

@vsppedro Do you want me to fix it, or just rerun the pipeline? 😄

@vsppedro
Copy link
Collaborator

vsppedro commented Mar 21, 2023

Hmmm, the rubocop is failing and I didn't change the file that it's breaking thinking

It's because this PR updates the "TargetRubyVersion" in the Rubocop file. We need to update the code according to this new version.

@vsppedro
Copy link
Collaborator

vsppedro commented Mar 21, 2023

I intent to merge this PR first: #1521

It will cause some conflict. If I merge yours first the other contribution would be lost. Sorry.

@HeitorMC
Copy link
Contributor Author

I intent to merge this PR first: #1521

It will cause some conflict. If I merge yours first the other contribution would be lost. Sorry.

Oh no problem, I was expecting that haha, don't worry!

@vsppedro vsppedro merged commit fababc3 into thoughtbot:main Mar 22, 2023
@vsppedro
Copy link
Collaborator

vsppedro commented Mar 22, 2023

Thank you for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants