Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop git ls-files in gemspec #1354

Merged
merged 3 commits into from Sep 13, 2020
Merged

Drop git ls-files in gemspec #1354

merged 3 commits into from Sep 13, 2020

Commits on Sep 11, 2020

  1. Drop git ls-files in gemspec 

    Closes: thoughtbot#1353

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    @utkarsh2102
    utkarsh2102 committed Sep 11, 2020
    Copy the full SHA
    f1086fa View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Add the Packaging extension of RuboCop 

    More about the extension can be found at:
https://docs.rubocop.org/rubocop-packaging/

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    @utkarsh2102
    utkarsh2102 committed Sep 12, 2020
    Copy the full SHA
    d95f5f7 View commit details
    Browse the repository at this point in the history

  2. Use require over require_relative for cross-lib calls 

    Avoid using `require_relative` with relative path to
lib. Use `require` instead.

More details about this cop can be found at:
https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#packagingrequirerelativehardcodinglib

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
    @utkarsh2102
    utkarsh2102 committed Sep 12, 2020
    Copy the full SHA
    0519f87 View commit details
    Browse the repository at this point in the history