Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop git ls-files in gemspec #1354

Merged
merged 3 commits into from Sep 13, 2020
Merged

Conversation

utkarsh2102
Copy link
Contributor

@utkarsh2102 utkarsh2102 commented Sep 11, 2020

Hi again 馃憢馃徎

As discussed in #1353, this PR drops git in gemspec, thereby also helping in smooth downstream maintenance (in Debian, Fedora, and so on).
Also adds the Packaging extension of RuboCop. More about it can be found on https://docs.rubocop.org/rubocop-packaging.

Closes: #1353

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

Closes: thoughtbot#1353

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Gemfile Show resolved Hide resolved
More about the extension can be found at:
https://docs.rubocop.org/rubocop-packaging/

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Avoid using `require_relative` with relative path to
lib. Use `require` instead.

More details about this cop can be found at:
https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#packagingrequirerelativehardcodinglib

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Copy link
Contributor Author

@mcmire, should be ready for your review now, could you please take a look? 馃槃

@mcmire mcmire merged commit 4ab77e8 into thoughtbot:master Sep 13, 2020
@mcmire
Copy link
Collaborator

mcmire commented Sep 13, 2020

Thank you for these changes! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop git in gemspec
4 participants