Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Pillow380NewArraySieve prescription #49

Closed
wants to merge 1 commit into from
Closed

Introduce Pillow380NewArraySieve prescription #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 26 additions & 0 deletions prescriptions/pi_/pillow/pillow3.8.0_new_array.yaml
View file
Open in desktop
@@ -0,0 +1,26 @@
units:
sieves:
- name: Pillow380NewArraySieve
type: sieve
should_include:
adviser_pipeline: true
dependency_monkey_pipeline: true
recommendation_types:
- performance
- security
- stable
- latest
- test
match:
- package_version:
name: pillow
version: "3.8.0"
index_url: "https://pypi.org/simple"
run:
log:
message: "Pillow in version 3.8.0 introduced a new array that did not match all numpy array parameters."
type: WARNING
stack_info:
- type: WARNING
message: "Pillow in version 3.8.0 filtered out"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to filter out pillow==3.8.0 for all stacks or only for those that are running with specific numpy versions?

Copy link
Contributor Author

@pacospace pacospace Jul 12, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run DM with a new script, to discover which versions are affected by the error TypeError: __array__() takes 1 positional argument but 2 were given? It seems the issue was introduced by Pillow, the logic in Numpy was there, but don't know since when.

Maybe we can ask the community from Pillow. cc @t-vi @hugovk :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any and all numpy versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much @t-vi!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the issue is dependent on numpy presence, this should be turned into a step pipeline unit and corresponding pillow version should be filtered only based on numpy presence.

https://thoth-station.ninja/docs/developers/adviser/prescription.html#steps

Otherwise, resolver will filter out all the pillow==3.8.0 versions, even for stacks that do not have the issue stated.

link: pillow_380