Introduce Pillow380NewArraySieve prescription #49
Conversation
Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
sesheta
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
size/S
|
/assign @fridex |
|
/cc @fridex |
| type: WARNING | ||
| stack_info: | ||
| - type: WARNING | ||
| message: "Pillow in version 3.8.0 filtered out" |
There was a problem hiding this comment.
Do we want to filter out pillow==3.8.0 for all stacks or only for those that are running with specific numpy versions?
There was a problem hiding this comment.
Should we run DM with a new script, to discover which versions are affected by the error TypeError: __array__() takes 1 positional argument but 2 were given? It seems the issue was introduced by Pillow, the logic in Numpy was there, but don't know since when.
Maybe we can ask the community from Pillow. cc @t-vi @hugovk :)
There was a problem hiding this comment.
thank you very much @t-vi!
There was a problem hiding this comment.
As the issue is dependent on numpy presence, this should be turned into a step pipeline unit and corresponding pillow version should be filtered only based on numpy presence.
https://thoth-station.ninja/docs/developers/adviser/prescription.html#steps
Otherwise, resolver will filter out all the pillow==3.8.0 versions, even for stacks that do not have the issue stated.
|
The Pillow version number is wrong, python-pillow/Pillow#5572 fixed a regression in 8.3.0 (Jul 1, 2021) not 3.8.0 (no such release exists). |
@hugovk thanks, sorry friday evening PRs :) |
|
Adjusted in #53 PTAL |
Signed-off-by: Francesco Murdaca fmurdaca@redhat.com
What type of PR is this?
/kind feature
Related issues or additional information of the supplied change
Fixes: #48
Related-To: python-pillow/Pillow#5572
Description
Introduce a Sieve Prescription for pipelines so that the resolver skips that package.
cc @t-vi