Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compactor: hold lock for a shorter amount of time #7265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compactor: hold lock for a shorter amount of time #7265

wants to merge 1 commit into from

Commits on Apr 8, 2024

  1. compactor: hold lock for a shorter amount of time 

    If we are constantly running compactor in a loop then we shouldn't pay
the price of constantly holding the lock in the garbage collection
function. What the lock holding means in practice that we have to wait
two or sometimes even three times the amount it takes to sync metas.
That doesn't make sense since we are running the compactor in a loop and
the compacted blocks are properly taken care of.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
    @GiedriusS
    GiedriusS committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    378c3de View commit details
    Browse the repository at this point in the history