compactor: hold lock for a shorter amount of time #7265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are constantly running compactor in a loop then we shouldn't pay the price of constantly holding the lock in the garbage collection function. What the lock holding means in practice that we have to wait two or sometimes even three times the amount it takes to sync metas. That doesn't make sense since we are running the compactor in a loop and the compacted blocks are properly taken care of. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are constantly running compactor in a loop then we shouldn't pay the price of constantly holding the lock in the garbage collection function. What the lock holding means in practice that we have to wait two or sometimes even three times the amount it takes to sync metas. That doesn't make sense since we are running the compactor in a loop and the compacted blocks are properly taken care of.