Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fixing warnings in react-app #7069

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

UI: Fixing warnings in react-app #7069

wants to merge 7 commits into from

Conversation

harsh-ps-2003
Copy link
Contributor

@harsh-ps-2003 harsh-ps-2003 commented Jan 17, 2024 •
edited

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes partially #7066

Verification

Some of the warnings are not fixed yet (WIP), others don't give warning when running make react-app

@harsh-ps-2003
fixing some warnings
a56c516 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@harsh-ps-2003
getting index to its original warning
4ea8314 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@harsh-ps-2003
revamping graphcontrol warning
6915d1b 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
GiedriusS
GiedriusS reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could also remove CI=false in the same PR to ensure that we don't get any warnings?

@harsh-ps-2003
fix status warnings
45e462e 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 17, 2024
@harsh-ps-2003
Merge branch 'main' into warnings
ba62bc6
@harsh-ps-2003
remove CI warnings check
d2d4a6b 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@harsh-ps-2003
Copy link
Contributor Author

harsh-ps-2003 commented Jan 19, 2024 •
edited

As I see data not defined here, replacing any to get rid of warnings is difficult! @GiedriusS

@harsh-ps-2003 harsh-ps-2003 mentioned this pull request Jan 19, 2024
Open
2 tasks
@yeya24
Copy link
Contributor

yeya24 commented Jan 23, 2024

Seems any still has issues?

@harsh-ps-2003
Copy link
Contributor Author

harsh-ps-2003 commented Jan 23, 2024 •
edited

Seems any still has issues?

Yup! I am finding it difficult to fix those last warnings! I am quite stuck so either I close the PR or maybe get it merged as most of the warnings are fixed, maybe someone else might help fix those last warnings after the merge while the issue is still open. @yeya24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harsh-ps-2003 @yeya24 @GiedriusS