adding null check to fix overlapping blocks #7058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
|
If it looks good I will add the changelog! @MichaHoffmann |
|
Seems duplicate with #6768? |
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
|
@harsh-ps-2003 Thanks for adding the test. We don't have to wait for #6768 since it has conflicts. |
GiedriusS
reviewed
Jan 15, 2024
| @@ -656,3 +658,37 @@ describe('Filtered block pools', () => { | |||
| expect(filteredBlockPoolArray[0].thanos.labels).toEqual(filteredBlocks[0].thanos.labels); | |||
| }); | |||
| }); | |||
|
|
|||
| const newBlockPools = blockPools; | |||
There was a problem hiding this comment.
Any reason all of these variables aren't moved into the test itself?
There was a problem hiding this comment.
Ah! moved the constants in the test. thanks
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
|
Note that react tests failed. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Pratap Singh harshpratapsingh8210@gmail.com
Changes
fixes #5359
Verification
Manually tested.
