New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuestDB Container module #5606
QuestDB Container module #5606
Conversation
modules/jdbc-test/src/main/java/org/testcontainers/db/AbstractContainerDatabaseTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jerrinot ! Can we add docs, please?
hi @eddumelendez, thanks for a quick reply! |
@jerrinot can you please add questdb to
|
@@ -0,0 +1,77 @@ | |||
package org.testcontainers.containers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package org.testcontainers.containers; | |
package org.testcontainers.questdb; |
Going ahead, new modules should use a package name following org.testcontainers.{module-name}
, to avoid Split Package issues with JMS.
@jerrinot just pinging to see if you are willing to work on the suggestions/requested changes 🙂 |
@eddumelendez hi, yes, totally. sorry for going silent. need to find some time. it's still on my radar. |
closing in favour of #5995 |
Hello, QuestDB has 8900+ GitHub stars, and I believe users will benefit from this.
I realise this is incomplete and documentation is lacking. I'm sending this as a draft to get some early feedback on whether you would consider merging this at all. If so, I would be keen to contribute this to TestContainers for other platforms, starting with Python.
Any feedback is much appreciated!