chore: refactor JDBC tests to avoid leaking DataSource & friends #5609
+260
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrinot
requested review from
rnorth,
bsideup,
kiview and
a team
as code owners
|
btw- if you think this is overkill then feel free to close it. no hard feelings :) |
eddumelendez
requested changes
Jul 28, 2022
There was a problem hiding this comment.
Thanks for the PR @jerrinot ! There is a couple of comments and we are ready to merge it.
Comment on lines
+50
to
+53
| return getDataSource0(container); | ||
| } | ||
|
|
||
| private HikariDataSource getDataSource0(JdbcDatabaseContainer<?> container) { |
There was a problem hiding this comment.
it can be kept. No need to create getDataSource0
| * @return | ||
| * @throws SQLException | ||
| * @deprecated use {@link #assertQuery(JdbcDatabaseContainer, String, ResultSetConsumer)} instead. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| */ | |
| */ | |
| @Deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performQuery()is leaking DataSources, Connections and Statements.Chances are it's also leaking ResutSets, unless a caller closes it. This is an attempt to fix it.
I kept the leaky method as there can be users outside the main repo.
I stumbled upon this while working on #5606