New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Couchbase module. closes #2447 #2491
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
059d9b5
Rewrite couchbase module. closes #2447
daschl 7613933
Wait until query respsonds with 200
daschl e02eab9
fixes
bsideup c81e7bf
add `getBootstrap*DirectPort()` methods, review fixes
bsideup c1e2273
Merge branch 'master' into daschl/couchbase-rewrite
bsideup 8d1cf17
Restore `getConnectionString()`
bsideup 81def1d
Apply suggestions from code review
bsideup 10f9e9d
Update docs
bsideup 067f4d8
Update docs (2)
bsideup File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 0 additions & 72 deletions
72
modules/couchbase/src/main/java/org/testcontainers/couchbase/AbstractCouchbaseTest.java
This file was deleted.
Oops, something went wrong.
69 changes: 69 additions & 0 deletions
69
modules/couchbase/src/main/java/org/testcontainers/couchbase/BucketDefinition.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/* | ||
* Copyright (c) 2020 Couchbase, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.testcontainers.couchbase; | ||
|
||
/** | ||
* Allows to configure the properties of a bucket that should be created. | ||
*/ | ||
public class BucketDefinition { | ||
|
||
private final String name; | ||
private boolean queryPrimaryIndex = true; | ||
private int quota = 100; | ||
|
||
public BucketDefinition(final String name) { | ||
this.name = name; | ||
} | ||
|
||
/** | ||
* Sets a custom bucket quota (100MB by default). | ||
* | ||
* @param quota the quota to set for the bucket. | ||
* @return this {@link BucketDefinition} for chaining purposes. | ||
*/ | ||
public BucketDefinition withQuota(final int quota) { | ||
if (quota < 100) { | ||
throw new IllegalArgumentException("Bucket quota cannot be less than 100MB!"); | ||
} | ||
this.quota = quota; | ||
return this; | ||
} | ||
|
||
/** | ||
* Allows to disable creating a primary index for this bucket (enabled by default). | ||
* | ||
* @param create if false, a primary index will not be created. | ||
* @return this {@link BucketDefinition} for chaining purposes. | ||
*/ | ||
public BucketDefinition withPrimaryIndex(final boolean create) { | ||
this.queryPrimaryIndex = create; | ||
return this; | ||
} | ||
|
||
public String getName() { | ||
return name; | ||
} | ||
|
||
public boolean hasPrimaryIndex() { | ||
return queryPrimaryIndex; | ||
} | ||
|
||
public int getQuota() { | ||
return quota; | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we add the original source of this file, for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment is invalid ;)