New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Couchbase module. closes #2447 #2491
Merged
Merged
Commits on Mar 27, 2020
-
Rewrite couchbase module. closes #2447
This changeset completely reworks the couchbase module and hopefully greatly improve the out-of-the-box experience. Note that this is a breaking change over the previous code because by intention it does NOT depend on SDK 2 so you can test SDK 2 and 3 with it at the same time. Highlights: - Removed the need for a SDK, so both 2 and 3 can be used with it. - Updated to 6.5.0 baseline and using alternate addresses for "proper" port exposure without having to rely on the socat proxy container like the previous version had to. - Allows to define which services should be exposed and handles states automatically (i.e. will not try to create the primary index if the query service is not enabled). Note that a bunch of tests have been removed since they are not adequate anymore. A side effect of the alternate address change is that older servers cannot be used. 6.5.0 is available in both CE and EE, and Couchbase in general allows EE versions to be used in development and testing so we should use it if we can.
Configuration menu - View commit details
-
Copy full SHA for 059d9b5 - Browse repository at this point
Copy the full SHA 059d9b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7613933 - Browse repository at this point
Copy the full SHA 7613933View commit details
Commits on Mar 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e02eab9 - Browse repository at this point
Copy the full SHA e02eab9View commit details
Commits on Apr 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c81e7bf - Browse repository at this point
Copy the full SHA c81e7bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1e2273 - Browse repository at this point
Copy the full SHA c1e2273View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d1cf17 - Browse repository at this point
Copy the full SHA 8d1cf17View commit details -
Apply suggestions from code review
Co-Authored-By: Kevin Wittek <kiview@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 81def1d - Browse repository at this point
Copy the full SHA 81def1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10f9e9d - Browse repository at this point
Copy the full SHA 10f9e9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 067f4d8 - Browse repository at this point
Copy the full SHA 067f4d8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.