Call conf.clamp for puma options to convert the default :environment Proc into a String #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know that I agree it should be the calling codes responsibility to call |
dentarg
reviewed
Oct 29, 2020
| @@ -28,6 +28,7 @@ | |||
| options = default_options.merge(options) | |||
|
|
|||
| conf = Rack::Handler::Puma.config(app, options) | |||
| conf.options.finalize_values | |||
There was a problem hiding this comment.
I think you can do this instead
Suggested change
| conf.options.finalize_values | |
| conf.clamp |
See
ndbroadbent
changed the title
ndbroadbent
force-pushed
the
finalize_puma_options
branch
from
bfca069
to
43a2b2a
Compare
|
Thanks @dentarg, you're right! This looks like the public API that we are meant to call. I have updated the PR |
ndbroadbent
force-pushed
the
finalize_puma_options
branch
2 times, most recently
from
49b0737
to
59de6e0
Compare
ndbroadbent
force-pushed
the
finalize_puma_options
branch
from
59de6e0
to
b21d90d
Compare
|
Note: I opened a different PR to fix some RuboCop warnings on the master branch: #2417 I've also included that commit in here just to check that the build is also passing for this branch |
|
Thanks |
etiennebarrie
added a commit
to Shopify/maintenance_tasks
that referenced
this pull request
Nov 7, 2020
Fixed upstream: teamcapybara/capybara#2413
lawrencewong
pushed a commit
to lawrencewong/maintenance_tasks
that referenced
this pull request
Apr 29, 2023
Fixed upstream: teamcapybara/capybara#2413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I just saw a deprecation warning when running Puma 5.0.3 in Ruby 2.7:
warning: deprecated Object#=~ is called on Proc. I initially raised the issue on the puma repo: puma/puma#2455But it turns out that this was a bug in Capybara: puma/puma#2455 (comment)
Capybara was not calling
#finalize_valuesto convert default Proc into a string. I've also tried to add a test to confirm that this is fixed, but not sure if it's the best way to test this.