Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clamp puma config to avoid deprecation warning #95

Merged
merged 1 commit into from
Aug 19, 2021
Merged

fix: clamp puma config to avoid deprecation warning #95

merged 1 commit into from
Aug 19, 2021

Conversation

grxy
Copy link
Contributor

@grxy grxy commented Aug 10, 2021

Changes

Calls clamp on the puma config to avoid an issue where the environment value has not been finalized from a proc to a string, leading to a deprecation warning.

@searls
Copy link
Member

searls commented Aug 10, 2021

Does configuration always respond to clamp across all versions of Puma? If not it should be gated behind a respond_to? check, right?

@grxy
Copy link
Contributor Author

grxy commented Aug 10, 2021

@searls

Does configuration always respond to clamp across all versions of Puma? If not it should be gated behind a respond_to? check, right?

I'll look into this. Thx.

@grxy
Copy link
Contributor Author

grxy commented Aug 10, 2021

@searls It looks like clamp was already defined as of v3.8.0, which I think is the minimum required by this gem. See https://github.com/puma/puma/blob/v3.8.0/lib/puma/configuration.rb#L211

@grxy
Copy link
Contributor Author

grxy commented Aug 19, 2021

@searls Any chance I can get a review on this? I confirmed with the author of Puma that clamp has been around since 3.0. Does it make sense that we can skip the respond_to? check since this gem requires puma >= 3.8.0?

@searls searls merged commit ca4dc24 into testdouble:main Aug 19, 2021
@searls
Copy link
Member

searls commented Aug 19, 2021

Sorry for the delay—miscommunication on our end. Landed in 0.5.2!

@grxy
Copy link
Contributor Author

grxy commented Aug 19, 2021

Thanks so much. Cheers!

@grxy grxy deleted the grex/clamp-puma-config branch August 19, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants