Normative: make String.prototype.matchAll throw for non-global regular expressions #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
has consensus
ljharb
approved these changes
Oct 2, 2019
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Oct 3, 2019
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Oct 3, 2019
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Oct 3, 2019
ljharb
added
has test262 tests
and removed
needs test262 tests
|
Tests are merged: tc39/test262#2389 |
|
Confirmed in person with @msaboff that the PR is good to go. |
…lar expressions (tc39#1716)
ljharb
force-pushed
the
throw-on-non-global-regexp-in-matchAll
branch
from
e93524c
to
1d0fe7c
Compare
mathiasbynens
added a commit
to tc39/proposal-string-replaceall
that referenced
this pull request
Oct 3, 2019
ljharb
added a commit
to es-shims/String.prototype.matchAll
that referenced
this pull request
Oct 3, 2019
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Oct 5, 2019
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Oct 5, 2019
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Oct 6, 2019
- Add a subscript R: Since _intValue_ is to be treated as a mathematical value, we should be comparing it to a mathematical zero. - Reinstate 'sec-static-semantics-elisionwidth' as an oldid; tc39#1124 removed the element-id 'sec-static-semantics-elisionwidth' - Reinstate 'sec-synchronizeeventset' as an oldid; tc39#1692 removed the element-id 'sec-synchronizeeventset'. - Reference 'ExportFromClause' from Annex A; tc39#1174 introduced the nonterminal 'ExportFromClause', but didn't reference it from Annex A. - Put asterisks around 'true' (from tc39#1716) - Fix typo "_eventRecords_" -> "_eventsRecord_" (from tc39#1692)
This was referenced Oct 21, 2019
yury-s
pushed a commit
to yury-s/webkit-http
that referenced
this pull request
Oct 23, 2019
https://bugs.webkit.org/show_bug.cgi?id=202838 Reviewed by Keith Miller. JSTests: * stress/string-matchall.js: Added. * test262/expectations.yaml: Mark four test cases as passing. Source/JavaScriptCore: * builtins/StringPrototype.js: (matchAll): Implement normative change from tc39/ecma262#1716. * builtins/BuiltinNames.h: * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): * runtime/RegExpConstructor.cpp: (JSC::esSpecIsRegExp): Added. * runtime/RegExpConstructor.h: Expose isRegExp to builtins. (This differs from @isRegExpObject by first checking for Symbol.match.) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
This was referenced Oct 26, 2019
mathiasbynens
added a commit
to v8/v8.dev
that referenced
this pull request
Nov 6, 2019
mathiasbynens
added a commit
to v8/v8.dev
that referenced
this pull request
Nov 6, 2019
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 24, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716.
This was referenced May 24, 2020
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 24, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 24, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 25, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 25, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 25, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 25, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 25, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 25, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 25, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 28, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
May 29, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
Jun 1, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
Jun 2, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
Jun 3, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
ljharb
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Jun 27, 2020
Proposal: https://github.com/tc39/proposal-string-replaceall Note that the changes to String.prototype.matchAll that were part of this proposal have already been merged here: tc39#1716. Co-authored-by: Jakob Gruber <jgruber@chromium.org> Co-authored-by: Mathias Bynens <mathias@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per October 2 2019 TC39 meeting consensus.
Tracking issues