Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain that string.matchAll(nonGlobalRegExp) throws #277

Merged
merged 1 commit into from Nov 6, 2019
Merged

Explain that string.matchAll(nonGlobalRegExp) throws #277

merged 1 commit into from Nov 6, 2019

Conversation

mathiasbynens
Copy link
Member

@mathiasbynens mathiasbynens added language features Explainers for new JavaScript or WebAssembly features and removed cla: yes labels Nov 6, 2019
schuay
schuay approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@schuay schuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshualitt
Copy link

LGTM

@mathiasbynens mathiasbynens merged commit eae17c5 into master Nov 6, 2019
@mathiasbynens mathiasbynens deleted the matchAll-non-global branch November 6, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuay schuay schuay approved these changes

Assignees

@schuay schuay

@joshualitt joshualitt

Labels
cla: yes language features Explainers for new JavaScript or WebAssembly features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mathiasbynens @joshualitt @schuay @googlebot