Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire user’s onChange handler when we update the combobox input value internally #1916

Merged
merged 3 commits into from Oct 10, 2022
Merged

Fire user’s onChange handler when we update the combobox input value internally #1916

merged 3 commits into from Oct 10, 2022

Commits on Oct 10, 2022

  1. Fire user’s onChange handler when we update the input value internally 

    We were directly setting `.value` previously. This does not fire the onChange handler given by the user for an input element in React >= 16. However, from a user’s perspective they’re seeing the value change and not being notified which means that their state is out of sync since this works as expected when the user is typing.
    @thecrypticace
    thecrypticace committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    1a51c26 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @thecrypticace
    thecrypticace committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    20147d9 View commit details
    Browse the repository at this point in the history

  3. Fix CS

    @thecrypticace
    thecrypticace committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    d561409 View commit details
    Browse the repository at this point in the history