Fire user’s onChange handler when we update the combobox input value internally #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were directly setting `.value` previously. This does not fire the onChange handler given by the user for an input element in React >= 16. However, from a user’s perspective they’re seeing the value change and not being notified which means that their state is out of sync since this works as expected when the user is typing.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Wait, but it means that both official example and example in https://tailwindui.com/components/application-ui/forms/comboboxes stopped to work. Official examples use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1875