New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested Struct and Enum Serialization #183
Conversation
Found a couple more issues with added test cases, will be adjusting this branch more. |
This PR fixes the bug I'm seeing with nested struct names getting duplicated, but it leaves in several debugging println! statements that render it unusable until fixed. :-)
|
Does this fix EDIT: According to my tests this doesn't seem to fix flatten. What exactly does this fix? |
See the test cases added as part of this PR. Without this PR, those test cases will fail. I no longer am working on the project with the dataset that led to this PR, so would recommend at least bringing in the test cases from this PR, and improving the implementation to make those tests pass. This PR is one possible implementation, but there's probably a better implementation. |
Should we maybe still try to merge it? I'm sure I wouldn't be alone to benefit from the serde support working better :) |
Since merging #490 both problems are fixed:
|
This PR fixes issues with nested struct and enum serialization, where the struct name will be serialized multiple times, or enum name will serialized. Unit variant enums are supported as well.