Added '$struct' tag to identify structs in newtype enum variants. #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out the serialization options included in quick-xml I came across an issue with the serialization of newtype variants in enums, where structs would have duplicated nodes when serialized. This relates to open issues like #183 and #346.
I believe there might be a better way to do this, but a very basic concept I came up with is to simply mark which enum variants contain a struct, and then skip adding an extra node for such variant.
This makes it for me for now, and maybe some others could benefit from it until we find the right way to do it.
I would like to look into an automatic way of doing this if someone has any ideas of how I could detect automatically if the given newvariant is a struct.
Let me know what you think, any feedback is welcome :)