[Cache] Fix irrelevant deprecation when connecting to Couchbase #54979
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bugfix/couchbase-deprecation
branch
from
f4204a0
to
4978107
Compare
derrabus
force-pushed
the
bugfix/couchbase-deprecation
branch
from
4978107
to
817420f
Compare
derrabus
changed the title
GromNaN
approved these changes
May 17, 2024
fabpot
approved these changes
May 21, 2024
|
Thank you @derrabus. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a connection for Couchbase, we currently always trigger a deprecation that we cannot opt out of. The reason is that
AbstractAdaptercalls the theisSupported()method of the deprecatedCouchbaseBucketAdapterclass before deciding in favor of its non-deprecated replacementCouchbaseCollectionAdapter.