[PhpUnitBridge] Add ExpectUserDeprecationMessageTrait #54593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
feature/expect-deprecation-polyfill
branch
3 times, most recently
from
5c769cc
to
24ff1b6
Compare
stof
reviewed
Apr 17, 2024
src/Symfony/Component/Cache/Tests/Adapter/CouchbaseCollectionAdapterTest.php
Show resolved
Hide resolved
derrabus
force-pushed
the
feature/expect-deprecation-polyfill
branch
from
24ff1b6
to
66430f3
Compare
derrabus
force-pushed
the
feature/expect-deprecation-polyfill
branch
2 times, most recently
from
435c552
to
6733c9b
Compare
derrabus
force-pushed
the
feature/expect-deprecation-polyfill
branch
from
6733c9b
to
d460d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 11 introduces a method
expectUserDeprecationMessage()which let's us define which deprecation messages we expect the tested code to raise. This new method can replace our ownexpectDeprecation()method once we upgrade to PHPUnit 11.This PR introduces a
ExpectUserDeprecationMessageTraitthat polyfills this method for older PHPUnit versions. This allowed me to run all tests that I've migrated toexpectUserDeprecationMessage()with PHPUnit 11.