Add types to constructors and private/final/internal methods (Batch II) #33709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Form/Extension/Core/DataTransformer/DateIntervalToStringTransformer.php
Outdated
Show resolved
Hide resolved
|
Thank you. I'm not sure about any of the changes on tests: they provide nothing quality-wise, and make merges more conflict-prone. |
derrabus
force-pushed
the
improvement/non-breaking-types-2
branch
from
9ed0817
to
b186826
Compare
On the last PR, we agreed that I could add types to tests that don't exist on the 3.4 branch. That should be the case for the Messenger and HttpClient tests that I've patched here. |
Tobion
reviewed
Sep 30, 2019
derrabus
force-pushed
the
improvement/non-breaking-types-2
branch
from
b186826
to
19c1ed9
Compare
nicolas-grekas
approved these changes
Oct 2, 2019
Tobion
force-pushed
the
improvement/non-breaking-types-2
branch
from
19c1ed9
to
9378eb4
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 7, 2019
…hods (Batch III) (derrabus) This PR was squashed before being merged into the 4.4 branch (closes #33770). Discussion ---------- Add types to constructors and private/final/internal methods (Batch III) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #32179, #33228 | License | MIT | Doc PR | N/A Followup to #33709, this time with: * Validator * VarDumper * Workflow * Yaml * all bridges * all bundles That should be the final batch. 😃 Commits ------- 6493902 Add types to constructors and private/final/internal methods (Batch III)
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
…nal methods (Batch II) (derrabus) This PR was squashed before being merged into the 4.4 branch (closes symfony#33709). Discussion ---------- Add types to constructors and private/final/internal methods (Batch II) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | symfony#32179, symfony#33228 | License | MIT | Doc PR | N/A Followup to symfony#33519, this time with: * Form * HttpClient * HttpKernel * intl * Ldap * Ldap * Lock * Messenger * Processor * PropertyInfo * Routing * Security * Serializer * Stopwatch * Translation Commits ------- 9378eb4 Add types to constructors and private/final/internal methods (Batch II)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #33519, this time with: