Add types to constructors and private/final/internal methods (Batch III) #33770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/non-breaking-types-3
branch
from
cf8c178
to
e4cfa7e
Compare
| @@ -59,9 +61,7 @@ public function testLoadUserByUsernameWithUserLoaderRepositoryAndWithoutProperty | |||
| { | |||
| $user = new User(1, 1, 'user1'); | |||
|
|
|||
| $repository = $this->getMockBuilder('Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface') | |||
There was a problem hiding this comment.
changes on this file should be reverted (and/or be submitted on 3.4)
There was a problem hiding this comment.
and/or be submitted on 3.4
My failed attempt to do so is documented as #33771. 馃檲
The changes are necessary because the mocks are currently incomplete and because of that they wouldn't pass a return type declaration I've added.
nicolas-grekas
approved these changes
Oct 7, 2019
nicolas-grekas
force-pushed
the
improvement/non-breaking-types-3
branch
from
e4cfa7e
to
6493902
Compare
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #33709, this time with:
That should be the final batch. 馃槂