Remove deprecated assertContains #32977
Conversation
|
Thanks, we just merged #32971 which does the same on 3.4 |
MarioBlazek
force-pushed
the
deprec-phpunit-assertContains
branch
from
7b09a9e
to
622c638
Compare
|
@nicolas-grekas PR rebased against 4.3 |
|
All the cases that fail with "mb_strpos() expects parameter 1 to be string, array given" should use assertContainsEquals instead |
|
Wait, assertContains is not deprecated. Some uses of it are. This should be more selective about those. |
| $this->assertContains('BaseBundle:controller:custom.format.engine', $templates); | ||
| $this->assertContains('::this.is.a.template.format.engine', $templates); | ||
| $this->assertContains('::resource.format.engine', $templates); | ||
| $this->assertStringContainsString('BaseBundle::base.format.engine', $templates); |
There was a problem hiding this comment.
templates is an array, you should revert and keep assertContains.
The deprecation is about using assertContains when the second argument is a string (ie. assertContains('foo', 'foobarbaz') )
Same comment for many changes bellow.
An easy way to spot theme, is to run test and revert reverting the failing tests ;-)
|
Thank you guys, I will update PR accordingly asap. |
|
@nicolas-grekas @jderusse tests now pass, but build for some strange reason is hanging too long. Did you experienced something similar before? |
|
@MarioBlazek tests should be back to OK with #33005 |
|
Tests are now OK, thanks @nicolas-grekas |
nicolas-grekas
force-pushed
the
deprec-phpunit-assertContains
branch
from
7b9c145
to
43acda6
Compare
|
Thank you @MarioBlazek. |
This PR was squashed before being merged into the 4.3 branch (closes #32977). Discussion ---------- Remove deprecated assertContains | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | symfony This PR replaces `assertContains()` with `assertStringContainsString()`. Commits ------- 43acda6 Remove deprecated assertContains
This PR was merged into the 4.3 branch. Discussion ---------- Fix deprecations on 4.3 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA Fix deprecations in branch 4.3 note: remaining deprecation `assertStringContainsString` will be fixed in #32977 * [ ] fix tests in branch 3.4 in #32981 Commits ------- 8fd16a6 Fix deprecation on 4.3
This PR replaces
assertContains()withassertStringContainsString().