Fix deprecations on 4.3 #33000
Merged
Fix deprecations on 4.3 #33000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Aug 6, 2019
jderusse
force-pushed
the
deprec-43
branch
2 times, most recently
from
ab1d931
to
39a4b52
Compare
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
jderusse
force-pushed
the
deprec-43
branch
3 times, most recently
from
4d6765b
to
d485174
Compare
jderusse
commented
Aug 7, 2019
| @@ -54,15 +54,19 @@ public function testProcess() | |||
| public function testProcessNotExistingActionParam() | |||
| { | |||
| $this->expectException('Symfony\Component\DependencyInjection\Exception\AutowiringFailedException'); | |||
| $this->expectExceptionMessage('Cannot autowire service "Symfony\Component\DependencyInjection\Tests\CompilerEslaAction": argument "$notExisting" of method "Symfony\Component\DependencyInjection\Tests\Compiler\ElsaAction::__construct()" has type "Symfony\Component\DependencyInjection\Tests\Compiler\NotExisting" but this class was not found.'); | |||
There was a problem hiding this comment.
This assertion triggers an exception in PHPUnit Because AutowiringFailedException::message is not a string but a class with a __toString method
src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
Outdated
Show resolved
Hide resolved
jderusse
commented
Aug 7, 2019
| $container = new ContainerBuilder(); | ||
|
|
||
| $container->register(B::class); | ||
| $cDefinition = $container->register('c', __NAMESPACE__.'\C'); | ||
| $cDefinition->setAutowired(true); | ||
|
|
||
| (new ResolveClassPass())->process($container); | ||
| (new AutowirePass())->process($container); | ||
|
|
||
| $this->assertCount(1, $container->getDefinition('c')->getArguments()); |
There was a problem hiding this comment.
container->getDefinition('c')->getArguments() equals to 0.
This assert were never reached because call to process triggers an exception and cautch by the former $this->expectException('Symfony\Component\DependencyInjection\Exception\RuntimeException');
jderusse
commented
Aug 7, 2019
| $container = new ContainerBuilder(); | ||
|
|
||
| $container->register(F::class); | ||
| $gDefinition = $container->register('g', __NAMESPACE__.'\G'); | ||
| $gDefinition->setAutowired(true); | ||
|
|
||
| (new ResolveClassPass())->process($container); | ||
| (new AutowirePass())->process($container); | ||
|
|
||
| $this->assertCount(3, $container->getDefinition('g')->getArguments()); |
jderusse
force-pushed
the
deprec-43
branch
2 times, most recently
from
fd6568d
to
046e45e
Compare
nicolas-grekas
approved these changes
Aug 7, 2019
23 tasks
jderusse
force-pushed
the
deprec-43
branch
5 times, most recently
from
68d1426
to
4edb17c
Compare
jderusse
commented
Aug 7, 2019
| $this->assertStringEqualsFile(__DIR__.'/Fixtures/proxy-factory.php', $factory); | ||
|
|
||
| require_once __DIR__.'/Fixtures/proxy-implem.php'; | ||
| eval(preg_replace('/^<\?php/', '', $implem)); |
There was a problem hiding this comment.
since ProxyManager 2.2 the suffix in properties is predictable, BUT it vary with version of dependencies installed. Which make a simple assertEquals unusable. Now, proxy-implem.php contains a pattern to match, and $implem contains the true code to evaluate.
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fix deprecations on 4.3 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA Fix deprecations in branch 4.3 note: remaining deprecation `assertStringContainsString` will be fixed in #32977 * [ ] fix tests in branch 3.4 in #32981 Commits ------- 8fd16a6 Fix deprecation on 4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecations in branch 4.3
note: remaining deprecation
assertStringContainsStringwill be fixed in #32977