[PhpUnitBridge] Add polyfill for expectException* methods #32869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
polyfill-phpunit-setexception
branch
from
951f008
to
dc7a2d7
Compare
Tobion
reviewed
Aug 1, 2019
|
Why is the PR for master? |
nicolas-grekas
changed the title
nicolas-grekas
changed the title
The reason is that the master version of the bridge is used to test all branches, so merging here first will unlock testing the PR on 3.4 (and we will merge this patch also on 3.4 then) |
jderusse
force-pushed
the
polyfill-phpunit-setexception
branch
from
dc7a2d7
to
d8c384b
Compare
nicolas-grekas
approved these changes
Aug 1, 2019
Tobion
reviewed
Aug 1, 2019
| } | ||
|
|
maxhelias
approved these changes
Aug 1, 2019
nicolas-grekas
force-pushed
the
polyfill-phpunit-setexception
branch
from
d8c384b
to
c7a8ce5
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 1, 2019
…s (jderusse) This PR was merged into the 5.0-dev branch. Discussion ---------- [PhpUnitBridge] Add polyfill for expectException* methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA this PR provides a polyfill for methods `setException`, `setExceptionMessage`, `setExceptionMessageRegExp` and `setExceptionCode` Commits ------- c7a8ce5 [Bridge/PhpUnit] Add polyfill for expectException*
nicolas-grekas
added a commit
that referenced
this pull request
Aug 1, 2019
…usse) This PR was merged into the 3.4 branch. Discussion ---------- Replace calls to setExpectedException by Pollyfill | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | need #32869 to be merged | Fixed tickets | #32844 | License | MIT | Doc PR | NA PhpUnit method `setExceptionException` has been deprecated seens 5.7. This PR replace theme by `exceptException` provide by the pollyfill. Commits ------- 41c02d7 Replace calls to setExpectedException by Pollyfill
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2019
…tring*() (Tobias Weichart) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] added polyfill for assertStringContainsString*() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | - this PR provides a polyfill for methods assertStringContainsString and assertStringContainsStringIgnoringCase in preparation for the PHPUnit 9 deprecations. PR follows the pattern of [this PR](#32869), hence the PR to master Commits ------- 1602441 [PhpUnitBridge] added polyfill for assertStringContainsString*()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR provides a polyfill for methods
setException,setExceptionMessage,setExceptionMessageRegExpandsetExceptionCode